9 (test only) RFR: 8180279: java/net/httpclient/whitebox/Driver.java failed due to timeout

2017-05-24 Thread Daniel Fuchs
[sent by mistake to core-libs-dev, sorry for cross posting] Hi, Please find below a test-only fix for: 8180279: java/net/httpclient/whitebox/Driver.java failed due to timeout https://bugs.openjdk.java.net/browse/JDK-8180279 The failing testcase is RawChannelTest. The test appears to be failin

Re: 9 (test only) RFR: 8180279: java/net/httpclient/whitebox/Driver.java failed due to timeout

2017-05-24 Thread Michael McMahon
Hi Daniel, Just so I understand correctly. The synchronization is needed to guarantee that the error situation expected actually occurs, where some data is left in this buffer on the client side and it's not just dealing with some strange implementation detail of the test? Michael On 24/05/20

Re: 9 (test only) RFR: 8180279: java/net/httpclient/whitebox/Driver.java failed due to timeout

2017-05-24 Thread Daniel Fuchs
On 24/05/2017 11:37, Michael McMahon wrote: Hi Daniel, Just so I understand correctly. The synchronization is needed to guarantee that the error situation expected actually occurs, where some data is left in this buffer on the client side and it's not just dealing with some strange implementatio

Re: 9 (test only) RFR: 8180279: java/net/httpclient/whitebox/Driver.java failed due to timeout

2017-05-24 Thread Michael McMahon
On 24/05/2017, 11:41, Daniel Fuchs wrote: On 24/05/2017 11:37, Michael McMahon wrote: Hi Daniel, Just so I understand correctly. The synchronization is needed to guarantee that the error situation expected actually occurs, where some data is left in this buffer on the client side and it's not

Re: 9 (test only) RFR: 8180279: java/net/httpclient/whitebox/Driver.java failed due to timeout

2017-05-24 Thread Michael McMahon
The change looks fine to me Daniel - Michael On 24/05/2017, 11:41, Daniel Fuchs wrote: On 24/05/2017 11:37, Michael McMahon wrote: Hi Daniel, Just so I understand correctly. The synchronization is needed to guarantee that the error situation expected actually occurs, where some data is left i