Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

> On Tue, Apr 18, 2017 at 7:08 AM, Vyom Tewari wrote: > ... > > Thanks for review, please find the updated > webrev(http://cr.openjdk.java.net/~vtewari/8165437/webrev0.6/index.html) The changes mainly look good to me, just a few comments: 1) src/java.base/unix/native/libnet/PlainSocketImpl.c

Re: [PATCH] 8035653: jdk8u152-b01 windows crash on DatagramSocket.getLocalAddress

> On 24 Apr 2017, at 14:27, Langer, Christoph wrote: > > Hi Alex, > > to me your patch looks good. > > But since I'm not a JDK8 Reviewer, someone with this merits has to review it. > @Chris: May I ask you to have a look? >> ... >> >> [1] http://cr.openjdk.java.net/~akasko/jdk8u/8035653/webre

[JDK 10] RFR: 8179273: sun.net.httpserver.LeftOverInputStream should stop attempting to drain the stream when the server is stopped

Hi, Please find below a fix for: 8179273: sun.net.httpserver.LeftOverInputStream should stop attempting to drain the stream when the server is stopped https://bugs.openjdk.java.net/browse/JDK-8179273 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8179273/webrev.00/ From the thread

Re: [JDK 10] RFR: 8179273: sun.net.httpserver.LeftOverInputStream should stop attempting to drain the stream when the server is stopped

> On 25 Apr 2017, at 14:48, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for: > > 8179273: sun.net.httpserver.LeftOverInputStream should stop > attempting to drain the stream when the server is stopped > https://bugs.openjdk.java.net/browse/JDK-8179273 > > webrev: > http://

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

Hi Chris, Vyom, I have preferences as expressed earlier, but no strong emotions. I can live with the fix as it is now. Thanks all, and Kind Regards, Thomas On Tue, Apr 25, 2017 at 3:31 PM, Chris Hegarty wrote: > > On Tue, Apr 18, 2017 at 7:08 AM, Vyom Tewari > wrote: > > ... > > > > Thanks f