Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-04-24 Thread Thomas Stüfe
Hi Vyom, sorry for the late response, I had vacation. Thanks for taking my suggestions! Here some remarks: --- I looked a little bit closer into the question why JVM_LEAF is used to wrap simple little functions like JVM_NanoTime or JVM_CurrentTimeMillis (among others). There is no hard technica

Re: [PATCH] 8035653: jdk8u152-b01 windows crash on DatagramSocket.getLocalAddress

2017-04-24 Thread Alex Kashchenko
Hi Christoph, On 04/19/2017 10:53 AM, Langer, Christoph wrote: Hi Alex, I've just quickly checked this and it seems worthwile to me to downport 8035653 to JDK8. As the patch will probably not apply cleanly to JDK8 after unshuffling [1] , you will need to create a new public review and post i

RE: [PATCH] 8035653: jdk8u152-b01 windows crash on DatagramSocket.getLocalAddress

2017-04-24 Thread Langer, Christoph
Hi Alex, to me your patch looks good. But since I'm not a JDK8 Reviewer, someone with this merits has to review it. @Chris: May I ask you to have a look? Thanks Christoph > -Original Message- > From: Alex Kashchenko [mailto:akash...@redhat.com] > Sent: Montag, 24. April 2017 15:22 > To

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-04-24 Thread Bernd Eckenfels
Can't you just keep a NET_Timeout using directly os::javaTimeNano()? Gruss Bernd -- http://bernd.eckenfels.net From: net-dev on behalf of Thomas Stüfe Sent: Monday, April 24, 2017 1:07:52 PM To: Vyom Tewari Cc: net-dev Subject: Re: JDK10 RFR: 8165437 Evaluate th