Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-11 Thread Daniel Fuchs
Hi, Please find below a new webrev that fixes an additional timeout ordering issue I discovered while testing: http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.02/ While doing some further tests after incorporating Chris's feedback I noticed that the new test and the TimeoutOrdering tes

Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-11 Thread Chris Hegarty
> On 11 Apr 2017, at 12:51, Daniel Fuchs wrote: > > Hi, > > Please find below a new webrev that fixes an additional timeout > ordering issue I discovered while testing: > > http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.02/ Thanks for going the extra mile on this one. Good catch, an

JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-04-11 Thread Vyom Tewari
Hi, Please review the code change for below issue. Bug: https://bugs.openjdk.java.net/browse/JDK-8165437 Webrev: http://cr.openjdk.java.net/~vtewari/8165437/webrev0.5/index.html This change will replace the "gettimeofday" to use the monotonic increasing clock(i used the existing functio

Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-11 Thread Michael McMahon
Looks good Daniel. Good catch with the timeout ordering bug. - Michael On 11/04/2017, 12:51, Daniel Fuchs wrote: Hi, Please find below a new webrev that fixes an additional timeout ordering issue I discovered while testing: http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.02/ While d