RFR: 8167178 Exported elements referring to inaccessible types in java.naming

2017-01-16 Thread Vyom Tewari
Hi All, Please review below the small fix for the issue. BugId : https://bugs.openjdk.java.net/browse/JDK-8167178 The compatibility impact is minimum as no code in JDK is currently depend on it. I will file a CCC today. Thanks, Vyom --- a/src/java.naming/share/classes/javax/naming/Compo

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

2017-01-16 Thread Alan Bateman
On 16/01/2017 09:10, Vyom Tewari wrote: Hi All, Please review below the small fix for the issue. BugId : https://bugs.openjdk.java.net/browse/JDK-8167178 The compatibility impact is minimum as no code in JDK is currently depend on it. I think this is okay, it is technically an API change bu

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

2017-01-16 Thread Chris Hegarty
Looks good. Thanks Vyom. -Chris. > On 16 Jan 2017, at 09:10, Vyom Tewari wrote: > > Hi All, > > Please review below the small fix for the issue. > > BugId : https://bugs.openjdk.java.net/browse/JDK-8167178 > > The compatibility impact is minimum as no code in JDK is currently depend on > i

RE: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-01-16 Thread Zeller, Arno
Hi Michael and Chris, I see that in with "RFR: 8172253 SetIfModifiedSince.java test fails with http return code 404" you fix a problem on macOS that does occur, because macOS is the only platform that sets a default proxy from the system settings. On all other platforms the system settings are