Hi Vyom,
thanks for looking at this. Overall your fix and test look good to me.
The coding to do the parent search and if required a child search in
Java_java_net_NetworkInterface_getByName0 could be done a bit more
straightforward, e.g. like this:
// search the list of interfaces by name
Hi Michael,
given the recent changes that were submitted (jigsaw update, aot)
I don't think Christoph's changes can be considered a major risk.
They have been worked on for quite a while now, and they are
tested well on our side.
So I really would appreciate if they could be submitted as-is.
Rewor
Hi Goetz,
Christoph has already done the work to split these changes into smaller
chunks, 8171075 and 8171077. He has reviews out, and they are on my list
to get to in the next few days. If it is ok, I’d like to proceed with this as
is,
form an initial skim they appear easier to review.
-Chris
Hello,
Could you please review the following change for [1]?
http://cr.openjdk.java.net/~prappo/8038079/webrev.00/
sun.net.www.protocol.http.HttpURLConnection defined in the java.base module uses
different authentication schemes. Among others there's a scheme called SPNEGO,
which is defined
On 13 Dec 2016, at 12:28, Pavel Rappo wrote:
>
> Hello,
>
> Could you please review the following change for [1]?
>
>http://cr.openjdk.java.net/~prappo/8038079/webrev.00/
Looks good. Maybe just a short comment in the module-info.class?
// to support SPNEGO from HttpURLConnection
-Chri
