Re: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8

2016-11-21 Thread Chris Hegarty
On 17/11/16 12:12, Langer, Christoph wrote: Hi, please review a downport of a few small fixes to JDK 8 which were done through bugs 8034174, 8034182 and 8048518 to JDK 9 already. Bug: https://bugs.openjdk.java.net/browse/JDK-8169865 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8169865.8

Re: HTTP client API

2016-11-21 Thread Tobias Thierer
Hi Michael - Some follow-up/updates on items from my previous email inline below: On Mon, Oct 31, 2016 at 6:13 PM, Tobias Thierer wrote: > > On Fri, Oct 28, 2016 at 12:28 PM, Michael McMahon < > michael.x.mcma...@oracle.com> wrote: > >> >> The intention behind those interfaces is primarily to p

Re: RFR(M): 8167420: remove redundant code path in unix/native/libnet/Inet4AddressImpl.c

2016-11-21 Thread Chris Hegarty
Hi Christoph, On 03/11/16 15:46, Langer, Christoph wrote: Hi again, I have to make one addition to my points: Java_java_net_Inet6AddressImpl_getLocalHostName: - made getaddrinfo/getnameinfo turnaround the default, before it was only used on solaris. But it should be the default since

Re: HTTP client API

2016-11-21 Thread Chris Hegarty
Tobias, If you look at the code in the sandbox [*], the notion of a default client has been removed. Having global static default instances is problematic. Http Clients are lightweight, easy to configure and pass around, if that is what you want. -Chris. [*] hg clone http://hg.openjdk.java.net/

RE: RFR(M): 8167420: remove redundant code path in unix/native/libnet/Inet4AddressImpl.c

2016-11-21 Thread Langer, Christoph
Hi Chris, thanks for looking into this. First of all I'm glad that you agree to make the getLocalHostname call consistent throughout all implementations. :) However, my feeling at the moment rather is to prefer just return the gethostname() API result instead of doing getaddrinfo/getnameinfo o

RE: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8

2016-11-21 Thread Langer, Christoph
Thanks, Chris. It's pushed: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/90d2c6ddcedd > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Montag, 21. November 2016 11:54 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net; jdk8u-...@openjdk.java.