On Mon, Oct 31, 2016 at 6:13 PM, Tobias Thierer wrote:
> On Fri, Oct 28, 2016 at 12:28 PM, Michael McMahon <
> michael.x.mcma...@oracle.com> wrote:
>>
>> 2.) HttpHeaders: I love that there is a type for this abstraction! But:
>>
>>-
>>
>>Why is the type an interface rather than a concrete
On 26 Oct 2016, at 10:33, Langer, Christoph wrote:
>
> Hi,
>
> please review the cleanup of “#ifdef AF_INET6” in libnet coding. I have
> opened a separate JIRA issue as requested
>
> This is a mailthread where it was already discussed:
> http://mail.openjdk.java.net/pipermail/net-dev/2016-O
Hello all,
Please review a small fix for tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8169002
WebRev: http://cr.openjdk.java.net/~skovalev/8169002/webrev.00/
Issue: Several tests from java/net/httpclient folder have undeclared
dependency on java.logging module. This issue leads the t
Hi Sergei,
I think it would be preferable to convert the tests to use System.getLogger.
Is that possible?
Thanks, Roger
On 11/1/2016 1:15 PM, Sergei Kovalev wrote:
Hello all,
Please review a small fix for tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8169002
WebRev: http://cr.openj
Hi Roger,
On 01/11/16 17:21, Roger Riggs wrote:
Hi Sergei,
I think it would be preferable to convert the tests to use
System.getLogger.
Is that possible?
Some of the tests want to configure the logging, rather
than simply produce traces - so they will need java.logging
to do that:
670
Hi Daniel,
It seemed useful to be able to run the test in as many environments as
possible
though realistically java.util.logging may be there too.
I don't see that setting the logging levels is intrinsic to the tests
and would be used
for debugging so perhaps that function can be dropped or
Hi Roger,
I think we agree :-)
On 01/11/16 18:01, Roger Riggs wrote:
Hi Daniel,
It seemed useful to be able to run the test in as many environments as
possible
though realistically java.util.logging may be there too.
I don't see that setting the logging levels is intrinsic to the tests
and wo
Hi,
Ok, leave the logging in. (There are currently 3 issues marked as
intermittent that refer to httpclient).
Roger
p.s. I'm also a fan of using the TEST.properties for test directives
that apply to multiple tests
in a directory. In this case, "modules = java.logging".
On 11/1/2016 2:3
On 1 Nov 2016, at 18:40, Roger Riggs wrote:
>
> Hi,
>
> Ok, leave the logging in. (There are currently 3 issues marked as
> intermittent that refer to httpclient).
>
> Roger
>
> p.s. I'm also a fan of using the TEST.properties for test directives that
> apply to multiple tests
> in a direc
Hi there,
please review the following patch for an intermittent failing test.
Converted it into plain java test and avoid free port anti-pattern.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8156504
Webrev:
http://cr.openjdk.java.net/~xiaofeya/8156504/webrev.00/
Thanks,
Felix
Good to see one more script test be changed to java, thank you Felix.
I'm not official reviewer, but some minor comments.
30 * @library /lib/testlibrary
31 * @build jdk.testlibrary.*
32 * @compile LookupTest.java
I noticed test requires testlibrary, but seems test do not actually
depen
11 matches
Mail list logo
