Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-29 Thread Vyom Tewari
Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8153674/webrev0.1/index.html ). I had removed the SO_REUSEPORT & spec from constructor. Thanks, Vyom On Thursday 29 September 2016 01:38 AM, Chris

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-29 Thread Chris Hegarty
> On 29 Sep 2016, at 09:16, Vyom Tewari wrote: > > Hi All, > > Please find the latest > webrev(http://cr.openjdk.java.net/~vtewari/8153674/webrev0.1/index.html). I > had removed the SO_REUSEPORT & spec from constructor. Thank you Vyom, this looks good to me. -Chris. > Thanks, > > Vyom >

Re: RFR(S): 8166850: No runtime error expected after calling NET_MapSocketOption

2016-09-29 Thread Chris Hegarty
On 28 Sep 2016, at 16:39, Langer, Christoph wrote: > > Hi, > > during my work on exception sites in the JDK, I spotted another minor place > that should be fixed. In the Windows native implementations of > DualStackPlainDatagramSocketImpl and DualStackPlainSocketImpl, there are > calls to ev

RE: RFR(S): 8166850: No runtime error expected after calling NET_MapSocketOption

2016-09-29 Thread Langer, Christoph
Pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/153b4781adcc Thanks, Chris, for reviewing. > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Donnerstag, 29. September 2016 13:40 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net > Subject: Re: R