Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-08-30 Thread Mark Sheppard
Hi perhaps there is an opportunity to do some refactoring here (... for me a "goto " carries a code smell! ) along the lines if (timeout) { nread = NET_ReadWithTimeout(...); } else { nread = NET_Read(...); } the NET_ReadWithTimeout (...) function will contain a restructuring of

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-08-30 Thread Vyom Tewari
Hi Mark, Thanks for the review, even i don't like "goto" , i wanted to do code changes as less as possible(not even refactoring) and "goto" helped me in this. I will incorporate the review comment and send the modified webrev. Thanks, Vyom On 8/30/2016 4:11 PM, Mark Sheppard wrote: Hi