Removal of NET_ThrowByNameWithLastError?

2016-08-04 Thread Langer, Christoph
Hi, following up my change for https://bugs.openjdk.java.net/browse/JDK-8158023 I'd like to discuss the removal of NET_ThrowByNameWithLastError and its replacement with JNU_ThrowByNameWithLastError. Currently NET_ThrowByNameWithLastError just adds the errno to a default message and then calls

Re: RFR 8162876: [TEST_BUG] sun/net/www/protocol/http/HttpInputStream.java fails intermittently

2016-08-04 Thread Svetlana Nikandrova
Kindly reminder. On 02.08.2016 20:25, Svetlana Nikandrova wrote: Pavel, Chris, thank you for you replays. I believe I addressed all Pavel's comments except the one mentioned by Chris below. I saw tests with a really long bug list in @bug so I think it's a good practice to avoid testbug numbe

RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation

2016-08-04 Thread Langer, Christoph
Hi, I had made a few more cleanups when I was working on NetworkInterface.c which I thought are worth contributing. Please review: http://cr.openjdk.java.net/~clanger/webrevs/8163181.1/ Bug: https://bugs.openjdk.java.net/browse/JDK-8163181 As always, changes were built and tested on Linux, AIX,

Re: Removal of NET_ThrowByNameWithLastError?

2016-08-04 Thread Matthew Hall
On Thu, Aug 04, 2016 at 10:15:38AM +, Langer, Christoph wrote: > To sum it up: The only added value of NET_ThrowByNameWithLastError is that > there could be cases where you might see an error number value - though I > think this is very unlikely to happen. But if you say this is valuable I >

Re: JDK 9 RFR of 8162745: content-types.properties files are missing some modern types

2016-08-04 Thread Chris Hegarty
> On 3 Aug 2016, at 14:32, Brian Burkhalter wrote: > > Please review at your convenience. > > Issue:https://bugs.openjdk.java.net/browse/JDK-8162745 > Patch:http://cr.openjdk.java.net/~bpb/8162745/webrev.00/ > Looks fine. -