Re: RFR 8144008: Setting NO_PROXY on an URLConnection is not complied with

2016-06-16 Thread Vyom Tewari
Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8144008/webrev0.1/index.html ), i got some off line comments from Chris. Thanks, Vyom On Tuesday 14 June 2016 12:11 PM, Vyom Tewari wrote: Hi All,

RFR [9] 8157166: Update spec to account for platforms that do not support multicast

2016-06-16 Thread Chris Hegarty
Some platforms do not support multicasting, but the current spec requires that it is supported. It seems reasonable to relax this, somewhat, so that multicasting is effectively optional on these platforms. java.net.MulticastSocket.joinGroup and java.nio.channels.MulticastChannel.join method spec

Re: RFR [9] 8157166: Update spec to account for platforms that do not support multicast

2016-06-16 Thread Alan Bateman
On 16/06/2016 16:03, Chris Hegarty wrote: Some platforms do not support multicasting, but the current spec requires that it is supported. It seems reasonable to relax this, somewhat, so that multicasting is effectively optional on these platforms. java.net.MulticastSocket.joinGroup and java.ni

Re: RFR [9] 8157166: Update spec to account for platforms that do not support multicast

2016-06-16 Thread Chris Hegarty
> On 16 Jun 2016, at 16:31, Alan Bateman wrote: > > On 16/06/2016 16:03, Chris Hegarty wrote: > >> Some platforms do not support multicasting, but the current spec requires >> that >> it is supported. It seems reasonable to relax this, somewhat, so that >> multicasting >> is effectively optio

Re: RFR [9] 8157166: Update spec to account for platforms that do not support multicast

2016-06-16 Thread Alan Bateman
On 16/06/2016 16:38, Chris Hegarty wrote: On 16 Jun 2016, at 16:31, Alan Bateman wrote: On 16/06/2016 16:03, Chris Hegarty wrote: Some platforms do not support multicasting, but the current spec requires that it is supported. It seems reasonable to relax this, somewhat, so that multicastin

Re: RFR 8144008: Setting NO_PROXY on an URLConnection is not complied with

2016-06-16 Thread Roger Riggs
Hi Vyom, Looks ok, Roger On 6/16/2016 10:35 AM, Vyom Tewari wrote: Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8144008/webrev0.1/index.html ), i got some off line comments from Chris. Thanks

Re: RFR 8144008: Setting NO_PROXY on an URLConnection is not complied with

2016-06-16 Thread Chris Hegarty
> On 16 Jun 2016, at 18:55, Roger Riggs wrote: > > Hi Vyom, > > Looks ok, +1. I attempted to add a test for https, and just realised that the javax.net.SocketFactory does not support Socket(Proxy). It may be worth capturing this issue somewhere, but it is way beyond the scope of this bug,