Re: RFR 8071660 :URLPermission not handling empty method lists correctly

2016-06-12 Thread Daniel Fuchs
Hi Vyom, This looks strange to me: 268 if(!this.methods.isEmpty() && that.methods.isEmpty()) 269 return true; 270 if(this.methods.isEmpty() && !that.methods.isEmpty()) 271 return false; 272 if(this.methods.isEmpty() && that.methods.isEmpty())

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-06-12 Thread Alan Bateman
On 11/06/2016 08:59, John Jiang wrote: Hi, Just restarted this job. On 2016/4/29 15:34, Alan Bateman wrote: On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from a