Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-06-11 Thread John Jiang
Hi, Just restarted this job. On 2016/4/29 15:34, Alan Bateman wrote: On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even tho

Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-11 Thread Pavel Rappo
Simone, What's your opinion on how send(Ping|Pong|Close) should work? I mean with "one outstanding send" policy you're advocating for, should all types of messages sent by an app honor this policy? If we allow Pings, unsolicited Pongs and Close messages to jump ahead of the "queue" and define th

Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-11 Thread Joakim Erdfelt
Ping and Pong can interleave between frames (if a large message is being broken up into frames that is). Ping and Pong goto the head of the frame queue (post-extension processing) in a manner of speaking. Close should occur after the actively being sent message (aka once a fin==true is encountere

Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-11 Thread Pavel Rappo
Well, okay. It's known and expected. My question was who's going to be in charge of this? The application or the implementation? In other words, who chops messages into frames (since we anyway have exposed it in the api)? Should an invocation of "sendPing()" be allowed before the CF returned by th