On 8 Jun 2016, at 03:36, Hamlin Li wrote:
>
> On 2016/6/8 4:27, Bradford Wetmore wrote:
>> May I suggest using example.com [1] and an arbitrary path instead on these
>> two examples, so that there's no chance of it being mistaken for a valid
>> URL. This example uses old hostnames that might c
Looks fine Amy.
-Chris.
> On 8 Jun 2016, at 01:48, Amy Lu wrote:
>
> sun/net/www/http/ChunkedOutputStream/checkError.java
> This test failed intermittently (JDK-8041924), and recently observed failing
> with high frequency.
>
> Please review this patch to put the test to problem list until J
Hi Kenji,
thanks for this very good point. I thought that JNU_ThrowByNameWithLastError
just tries to throw the exception manually and if that fails it calls
JNU_ThrowByName which basically does the same. But I missed the point that it
does the conversion and tries JNU_ThrowByName only as fallba
> On 7 Jun 2016, at 18:42, Roger Riggs wrote:
>
> Hi Pavel,
>
> Looks fine.
>
> WebSocket.java:
> - line 82: I'd replace 'never' with 'does not'; it is more like a statement
> for fact and less a guarantee.
>
> - LIne 54: The notation "{@code .onX}" seems unnecessary, is quite cryptic,
> a
+1,
Thanks, Roger
On 6/8/2016 9:13 AM, Pavel Rappo wrote:
On 7 Jun 2016, at 18:42, Roger Riggs wrote:
Hi Pavel,
Looks fine.
WebSocket.java:
- line 82: I'd replace 'never' with 'does not'; it is more like a statement
for fact and less a guarantee.
- LIne 54: The notation "{@code .onX}" se
Hi Chris,
I now took time to look at your proposal based on ioctl calls. This looks very
good. I came up with some modifications to your patch and created another
webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8158519.1/
This builds on Linux, AIX, Solaris and Mac and the basic test to lis
Christoph,
You should not remove conversion codes (platform string to Java String)
at JNU_ThrowByNameWithLastError,
and you have to add conversion codes at JNU_ThrowByNameWithMessageAndLastError.
It seems that you assume strerror returns only ascii characters, but actually
not.
It depends on the
Looks good, thanks.
brad
On 6/8/2016 1:16 AM, Chris Hegarty wrote:
On 8 Jun 2016, at 03:36, Hamlin Li wrote:
On 2016/6/8 4:27, Bradford Wetmore wrote:
May I suggest using example.com [1] and an arbitrary path instead on these two
examples, so that there's no chance of it being mistaken fo
