Simone,
> On 1 Jun 2016, at 18:31, Simone Bordet wrote:
>
> I'm not sure it's worth encouraging to write application data from a
> onPing() or onPong() listener.
> My take on the issue is that upon receiving a Ping, the implementation
> should send a Pong "as soon as it is practical".
> I don't
Simone,
> On 31 May 2016, at 23:05, Simone Bordet wrote:
>
> I think this class exposes too many failure codes that applications
> *must not* be able to use.
> For example, 1002 is not something that the application can ever send,
> only the implementation can, and having a public API to create
Hi,
On Thu, Jun 2, 2016 at 12:27 PM, Pavel Rappo wrote:
> OK. The only thing is that I would leave returned CS from onPing/onPong.
> Remember we discussed that CompletionStage (or CompletableFuture) serves the
> purpose of an asynchronous feedback: "Hey, I'm done with this data". I think
> this w
Hi,
On Thu, Jun 2, 2016 at 1:24 PM, Pavel Rappo wrote:
> Good point. On the other hand, I was wondering if their semantics is
> definitely
> bound to WebSocket Protocol itself? i.e. can they be reused to indicate
> subprotocol issues, or pre-agreed format, etc.?
>
> 1002
>
> 1002 indicates
Doychin, et al,
I finally got time to look at the issue you reported and your suggested patch.
I filed
8158519 [1] to track the issue. I think your suggested patch may be ok, but I
just
wanted to push on the ioctl approach. I found an alternative, and verified that
it
works as expected. Pleas
For the record, this issue is tracked by 8158519 [1], and discussion will
continue
on another thread:
http://mail.openjdk.java.net/pipermail/net-dev/2016-June/009885.html
-Chris.
[1] https://bugs.openjdk.java.net/browse/JDK-8158519
> On 30 May 2016, at 13:51, Doychin Bondzhev wrote:
>
> At
> On 2 Jun 2016, at 13:00, Simone Bordet wrote:
>
> Furthermore, I'm not convinced there should be a parameterless sendClose().
> The WebSocket protocol itself *mandates* that the Close message must
> have a code
Regardless of your API proposal, where did you find that in the RFC?
Here's what I
Hi,
On Thu, Jun 2, 2016 at 2:51 PM, Pavel Rappo wrote:
> Regardless of your API proposal, where did you find that in the RFC?
Duh, I misread the RFC.
It says that *if* there is a body, then there is a code.
However, in 7.1.5:
"If this Close control frame contains no status code, _The WebSocket
The following networking tests have been seen to fail from a timeout, when the
host
is not accessible. These tests have nothing whatsoever to do with testing of
network
connections, they simply want to test the HTTP client implementation. This
issue
proposes to change the tests from using the
Hi Chris,
looks fine but a couple of questions/suggestions.
CookieManagerTest.java:
- the new definition of localHostAddr could probably be moved to a
class static and be used instead of the "127.0.0.1" literal (line 97).
- Does the use of the IPV4 loopback address work even in the case of
Hi Chris,
I had already created a bug report for this:
https://bugs.openjdk.java.net/browse/JDK-8158170 in the meanwhile but
unfortunately, by mistake, I had just sent this information to Doychin and not
to the mailing list. So, feel free to close and mark my bug as duplicate.
I also started w
All I can say is thank you ;-)
I can confirm that it works here to.
On Thu, Jun 2, 2016 at 5:53 PM, Langer, Christoph
wrote:
> Hi Chris,
>
> I had already created a bug report for this:
> https://bugs.openjdk.java.net/browse/JDK-8158170 in the meanwhile but
> unfortunately, by mistake, I had ju
Chris,
Looks good for me. Only minor nits (no need to re-review).
1040 missed space before {
1158 please, add comment and {} around continue.
1938 I'm not sure that check for IFF_POINTOPOINT is necessary (but
don't mid to leave it). Do you know the case when both flags are set?
-Dmitry
On 20
Hi,
Could you please review the following change for JDK-8156650?
http://cr.openjdk.java.net/~prappo/8156650/webrev.01/
This change addresses some WebSocket API refinements and enhancements from [1].
1. Remove method `WebSocket#sendText(ByteBuffer message, boolean isLast)`
This API sees Text m
On 2 Jun 2016, at 14:37, Roger Riggs wrote:
>
> Hi Chris,
>
> looks fine but a couple of questions/suggestions.
Thanks for looking at this Roger.
> CookieManagerTest.java:
>
> - the new definition of localHostAddr could probably be moved to a class
> static and be used instead of the "127.0.
Hi Chris,
Thanks for the updates and explanations; looks fine.
Roger
On 6/2/2016 3:12 PM, Chris Hegarty wrote:
On 2 Jun 2016, at 14:37, Roger Riggs wrote:
Hi Chris,
looks fine but a couple of questions/suggestions.
Thanks for looking at this Roger.
CookieManagerTest.java:
- the new de
Simone,
> On 2 Jun 2016, at 14:09, Simone Bordet wrote:
>
> I am not opposed to have a utility method sendClose() parameterless,
> but I don't think that it's worth an Optional in onClose(), given the
> semantic defined by 7.1.5.
It all boils down to how apps use contents of Close messages they
Hi,
On Thu, Jun 2, 2016 at 10:40 PM, Pavel Rappo wrote:
> 1. Are there any cases where the app needs to know that Close message was in
> fact
> empty?
Not that I know.
> 2. Does the app behaviour (especially, parsing the reason phrase/description)
> depend on the status code?
Not much really.
18 matches
Mail list logo
