RFR 8157811 [9] Additional minor fixes and cleanups in NetworkInterface.c

As a follow up to JDK-8156521, and when comparing against the version of this file in jdk8u-dev a few minor issues were noticed. There is a free of a memory structure that was missed somehow in the 9 version of this file ( it is already in the 8 version ). The remaining few changes are just some

Re: RFR 8157811 [9] Additional minor fixes and cleanups in NetworkInterface.c

On 25/05/2016 10:50, Chris Hegarty wrote: As a follow up to JDK-8156521, and when comparing against the version of this file in jdk8u-dev a few minor issues were noticed. There is a free of a memory structure that was missed somehow in the 9 version of this file ( it is already in the 8 versio

Re: RFR 8157811 [9] Additional minor fixes and cleanups in NetworkInterface.c

Hi Chris, the fix for 8068028 was marked 9-na for some reason, as such afaik the changes were not propagated to JDK9, which changed its src tree structure at that time (i think, jdk8 were on solaris files), parfait may not have highlighted them in that context afaik the other changes in tha

RE: RFR 8157811 [9] Additional minor fixes and cleanups in NetworkInterface.c

Hi Chris, looks nice, I had seen some of these places, too. Here is another one which you could add: --- a/src/java.base/unix/native/libnet/NetworkInterface.c Tue May 24 10:14:41 2016 -0700 +++ b/src/java.base/unix/native/libnet/NetworkInterface.c Wed May 25 14:56:31 2016 +0200 @@

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

Hi Chris, thank you for your comments. Please see updated review. (I left braces in one line "if" blocks, hope it wasn't strong objection) http://cr.openjdk.java.net/~snikandrova/8136933/webrev.04/ Tested as standalone 1 test ma

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

On 25 May 2016, at 14:04, Svetlana Nikandrova wrote: > > Hi Chris, > > thank you for your comments. Please see updated review. (I left braces in one > line "if" blocks, hope it wasn't strong objection) > > http://cr.openjdk.java.net/~snikandrova/8136933/webrev.04/ >

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

Thank you, Chris! On 25.05.2016 16:08, Chris Hegarty wrote: On 25 May 2016, at 14:04, Svetlana Nikandrova wrote: Hi Chris, thank you for your comments. Please see updated review. (I left braces in one line "if" blocks, hope it wasn't strong objection) http://cr.openjdk.java.net/~snikandrov

Re: RFR 8157811 [9] Additional minor fixes and cleanups in Networking native code

Thanks. I included it, though it may not show in the webrev ( white space change ) I generalise the issue to cover a few other minor issues. Webrev updated in-place: http://cr.openjdk.java.net/~chegar/8157811/ -Chris. > On 25 May 2016, at 13:59, Langer, Christoph wrote: > > Hi Chris, > >

Re: RFR 8157811 [9] Additional minor fixes and cleanups in Networking native code

Chris, Looks good for me! On 2016-05-25 16:22, Chris Hegarty wrote: > Thanks. I included it, though it may not show in the webrev ( white space > change ) > > I generalise the issue to cover a few other minor issues. > > Webrev updated in-place: > http://cr.openjdk.java.net/~chegar/8157811/