JEP 110: leeway for API changes?

2016-05-19 Thread Anthony Vanelverdinghe
Hi With the JDK's "Feature Complete" milestone coming up next week: how much leeway is there still for API changes? I've made API suggestions (a.o. in [1]), ranging from changing HttpResponse.multiProcessor::onStart's return type (from BiFunction<..., Boolean> to BiPredicate), to building on

Re: JEP 110: leeway for API changes?

2016-05-19 Thread Simone Bordet
Hi, On Thu, May 19, 2016 at 3:54 PM, Anthony Vanelverdinghe wrote: > Hi > > With the JDK's "Feature Complete" milestone coming up next week: how much > leeway is there still for API changes? I've made API suggestions (a.o. in > [1]), ranging from changing HttpResponse.multiProcessor::onStart's re

RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-19 Thread Svetlana Nikandrova
Hello, please review additional test for Solaris SO_FLOW_SLA socket option. Test checks that SO_FLOW_SLA option is supported on Solaris 11.2+ and not supported on other platforms. http://cr.openjdk.java.net/~snikandrova/8136933/webrev.00/

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-19 Thread Artem Smotrakov
Hi Svetlana, Please see a couple of comments below. I'll leave the final review to official reviewers. 1. You may use test/lib/testlibrary/jdk/testlibrary/OSInfo.java to check OS type. I think it also may be good to add getSolarisVersion() to OSInfo.java (see getWindowsVersion() method) Yo

Re: RFR 8157105: HTTP/2 client hangs in blocking mode if an invalid frame has been received

2016-05-19 Thread Roger Riggs
Hi Michael, Look ok, A one line description of the error it is trying to produce would be a good addition. Either in comment, javadoc or @summary Roger On 5/18/2016 12:55 PM, Michael McMahon wrote: Could I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/81571