Could I get the following change reviewed please? There are three small
changes
1) enhancements to RawChannel API used by websocket implementation
2) fix the test case problem where channel might not be in non-blocking mode
(also remove erroneous asssertion check)
3) Remove (unused) and un
This looks good, Michael. Thanks.
> On 16 May 2016, at 12:07, Michael McMahon
> wrote:
>
> Could I get the following change reviewed please? There are three small
> changes
>
> 1) enhancements to RawChannel API used by websocket implementation
>
> 2) fix the test case problem where channel m
Hi Michael,
+1
HttpClientImpl.java: Unless a large number of classes are needed,
individual imports are preferred.
(Maybe the IDE did that for you, in which the IDE should be reconfigured.)
Roger
On 5/16/2016 7:07 AM, Michael McMahon wrote:
Could I get the following change reviewed please?
Thanks Roger. What would the consensus be on what 'a large number' is?
- Michael
On 16/05/16 15:11, Roger Riggs wrote:
Hi Michael,
+1
HttpClientImpl.java: Unless a large number of classes are needed,
individual imports are preferred.
(Maybe the IDE did that for you, in which the IDE should
Hi,
Large: not a fixed number; but enough that if you glance at them and
do not know how many.
Or: So many that anyone would say they tried to read it and lost track
of how many. TL;DR
I would say 8-10. In immutable collections; 10 was the number for the
threshold in the new List const
On 12.05.2016 13:18, Ivan St. Ivanov wrote:
Hello Alan,
If that is the showstopper for moving this change forward,
Quoting from the very first step of the OpenJDK contribution guide at
http://openjdk.java.net/contribute/
"If you haven't yet signed the Oracle Contributor Agreement (OCA) th
