Christoph,
Looks good for me (Reviewed).
Few more space nits (no need to re-review)
1141 Missed space around = in i=0
1890 extra space after (
2068 wrong indent
-Dmitry
On 2016-05-10 12:54, Langer, Christoph wrote:
> Hi all,
>
>
>
> can I please get a review for a change to NetworkInter
On 11 May 2016, at 07:44, vyom wrote:
> Hi All,
>
> Please review the following simple fix for the
> issue(https://bugs.openjdk.java.net/browse/JDK-8154234).
>
>hg rm src/java.base/share/classes/sun/net/www/protocol/netdoc/Handler.java
This seems fine to me Vyom. Thanks.
-Chris.
Hi Christoph,
On 11 May 2016, at 08:43, Dmitry Samersoff wrote:
>> ...
>> bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521
>>
>> webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/
I think this is mainly fine, and good to have such cleanup in this area.
I agree with the
On 11/05/2016 09:50, Chris Hegarty wrote:
Hi Christoph,
On 11 May 2016, at 08:43, Dmitry Samersoff wrote:
...
bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521
webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/
I think this is mainly fine, and good to have such clean
Hi,
@Chris: As for your points:
> I agree with the replacement of strcpy with strncpy, but I think we should
> explicitly null terminate in case the src is greater or equal to the dst
> buffer
> size. This is done elsewhere in this file too, e.g.
>
>strncpy(buf, input, sizeof(buf) - 1);
>
On 11 May 2016, at 10:21, Langer, Christoph wrote:
> Hi,
>
> @Chris: As for your points:
>
>> I agree with the replacement of strcpy with strncpy, but I think we should
>> explicitly null terminate in case the src is greater or equal to the dst
>> buffer
>> size. This is done elsewhere in thi
the declaration in of plen (also scope and dad_status) as an int in
enumIPv6Interfaces would appear to be done to align with
its use in fscanf, even though it is a two character conversion.
So would it not be more appropriate to cast it as a short when passed to
addif ?
the name plen would als
Hi again,
I'm done with the new version:
http://cr.openjdk.java.net/~clanger/webrevs/8156521.1/
I now tried to break lines that are too long and also fixed some other space
and indentation issues.
To incorporate Mark's suggestions regarding plen in enumIPv6Interfaces, I
consistently renamed i
