Re: RFR JDK-8087113: Websocket API and implementation

2016-04-07 Thread Pavel Rappo
> On 6 Apr 2016, at 21:28, Roger Riggs wrote: > >>> Reader.java: >>> - line 137: Why should the reader force a new task? Should it be left to >>> the subscriber to >>>decide whether its processing is lightweight and can be done immediately >>> or to re-submit to its own executor. >>> >>

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Simone Bordet
Michael, On Wed, Apr 6, 2016 at 4:08 PM, Michael McMahon wrote: > Hi, > > This is the webrev for the HTTP/2 part of JEP 110. > > http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/index.html Can I ask how you guys apply webrevs to the JDK 9 source tree ? I would prefer to review in an IDE rat

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Michael McMahon
On 07/04/16 11:20, Simone Bordet wrote: Michael, On Wed, Apr 6, 2016 at 4:08 PM, Michael McMahon wrote: Hi, This is the webrev for the HTTP/2 part of JEP 110. http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/index.html Can I ask how you guys apply webrevs to the JDK 9 source tree ? I w

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Pavel Rappo
> On 7 Apr 2016, at 11:20, Simone Bordet wrote: > > Can I ask how you guys apply webrevs to the JDK 9 source tree ? > I would prefer to review in an IDE rather than in textual mode, but I > have not found instructions on how to apply a webrev to a source tree. Sure, each webrev should contain a

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Simone Bordet
Hi, On Thu, Apr 7, 2016 at 12:22 PM, Michael McMahon wrote: > Simone, > > The webrev should include a patch file that you can apply to > the source tree. The link is at the top of the page (jdk.patch) Tried that with patch -p1 < jdk.patch I get a lot of rejects. I am applying your HTTP/1.1 pa

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Michael McMahon
On 07/04/16 11:28, Simone Bordet wrote: Hi, On Thu, Apr 7, 2016 at 12:22 PM, Michael McMahon wrote: Simone, The webrev should include a patch file that you can apply to the source tree. The link is at the top of the page (jdk.patch) Tried that with patch -p1 < jdk.patch I get a lot of reje

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Simone Bordet
Hi, On Wed, Apr 6, 2016 at 4:08 PM, Michael McMahon wrote: > Hi, > > This is the webrev for the HTTP/2 part of JEP 110. > > http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/index.html Before I dive further into this, seems to me that the implementation is blocking; not the API which are pro

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Michael McMahon
On 07/04/16 14:19, Simone Bordet wrote: Hi, On Wed, Apr 6, 2016 at 4:08 PM, Michael McMahon wrote: Hi, This is the webrev for the HTTP/2 part of JEP 110. http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/index.html Before I dive further into this, seems to me that the implementation i

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Simone Bordet
Hi, On Thu, Apr 7, 2016 at 3:27 PM, Michael McMahon wrote: > At the lowest level the implementation uses two threads per TCP connection, > one for reading and one for writing. Ugh. > I do plan to change that to dispatch from > the selector > and execute the reads and writes asynchronously. It's

Re: RFR: 8087124 HTTP/2 implementation

2016-04-07 Thread Michael McMahon
On 07/04/16 14:37, Simone Bordet wrote: Hi, On Thu, Apr 7, 2016 at 3:27 PM, Michael McMahon wrote: At the lowest level the implementation uses two threads per TCP connection, one for reading and one for writing. Ugh. I do plan to change that to dispatch from the selector and execute the rea