Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

please find that updated webrev(http://cr.openjdk.java.net/~vtewari/7167293/webrev0.3 ), I incorporated Roger's comments. Thanks, Vyom On Wednesday 23 March 2016 10:04 PM, Roger Riggs wrote: Hi Vyom, I think it should be the case that

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi Vyom, A minor cleanup to reduce the size of the little used code. Create the FNFE before checking and closing. Then the form of the cleanup code will be consistent and there will be less code. For example, +FileNotFoundException fnfe = new FileNotFoundException(fullpath);

8150234: Windows 10 App Containers disallow access to ICMP calls

Hi folks, Looking for a review for this change. Basically https://bugs.openjdk.java.net/browse/JDK-8135305 abandoned the old TCP echo isReachable check in favour of Windows' ICMP calls on supported platforms. Unfortunately it turns out that Windows 10's new App Containers don't actually allow

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi, Please find the updated webrev. http://cr.openjdk.java.net/~vtewari/7167293/webrev0.4/index.html Thanks, Vyom On Tuesday 29 March 2016 07:49 PM, Roger Riggs wrote: Hi Vyom, A minor cleanup to reduce the size of the lit

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Looks good, Thanks, Roger On 3/29/2016 11:00 AM, vyom wrote: Hi, Please find the updated webrev. http://cr.openjdk.java.net/~vtewari/7167293/webrev0.4/index.html Thanks, Vyom On Tuesday 29 March 2016 07:49 PM, Roger Rigg

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

On 29 Mar 2016, at 16:20, Roger Riggs wrote: > Looks good, +1 Does the test need to be run in othervm mode ? -Chris. > Thanks, Roger > > > On 3/29/2016 11:00 AM, vyom wrote: >> Hi, >> >> Please find the updated webrev. >> http://cr.openjdk.java.net/~vtewari/7167293/webrev0.4/index.html

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

On Tuesday 29 March 2016 09:10 PM, Chris Hegarty wrote: On 29 Mar 2016, at 16:20, Roger Riggs wrote: Looks good, +1 Does the test need to be run in othervm mode ? I don't think othervm mode required, do you wants to me to generate another webrev(0.5) ? -Chris. Thanks, Roger On 3/29/

Re: RFR JDK-8087113: Websocket API and implementation

Hi Pavel, >> 215 .append(" >> rem=").append(b.remaining()).append("]").toString(); >> >> Please use ']' instead of "]”. >> >> 222 >> .append("[len=").append(s.length()).append("]").toString(); >> >> Please use ']' instead of "]”. > > I believe since JEP 280 [1

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

On 29 Mar 2016, at 17:38, vyom wrote: > On Tuesday 29 March 2016 09:10 PM, Chris Hegarty wrote: >> On 29 Mar 2016, at 16:20, Roger Riggs wrote: >> >>> Looks good, >> +1 >> >> Does the test need to be run in othervm mode ? > I don't think othervm mode required, do you wants to me to generate an