Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-21 Thread vyom
Hi, i modified the existing ftp server that we are using it for our testing so that when server starts it will return a response which contains some empty new lines. This change will ensures that readServerResponse() throws the "IndexOutOfBoundsException" which we are catching. As existing t

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-21 Thread Chris Hegarty
On 21/03/16 08:11, vyom wrote: Hi, i modified the existing ftp server that we are using it for our testing so that when server starts it will return a response which contains some empty new lines. This change will ensures that readServerResponse() throws the "IndexOutOfBoundsException" which we

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

2016-03-21 Thread vyom
Hi, Please find the updated webrev, got some off line comment from Chris. http://cr.openjdk.java.net/~vtewari/7167293/webrev0.2/index.html Thanks, Vyom On Thursday 17 March 2016 12:30 PM, vyom wrote: please find the updated

Re: [9] RFR: 8060097: sun/net/idn/TestStringPrep.java failed.

2016-03-21 Thread Naoto Sato
Pinging. Can anyone please review this simple fix? Naoto On 3/18/16 10:53 AM, Naoto Sato wrote: Hello, Please review the fix to the following bug: https://bugs.openjdk.java.net/browse/JDK-8060097 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8060097/webrev.00/ The test

Re: [9] RFR: 8060097: sun/net/idn/TestStringPrep.java failed.

2016-03-21 Thread Michael McMahon
Looks good Naoto. - Michael. On 21/03/16 15:19, Naoto Sato wrote: Pinging. Can anyone please review this simple fix? Naoto On 3/18/16 10:53 AM, Naoto Sato wrote: Hello, Please review the fix to the following bug: https://bugs.openjdk.java.net/browse/JDK-8060097 The proposed fix is located

Re: [9] RFR: 8060097: sun/net/idn/TestStringPrep.java failed.

2016-03-21 Thread Roger Riggs
Hi Naoto, Look fine. Roger On 3/21/2016 11:19 AM, Naoto Sato wrote: Pinging. Can anyone please review this simple fix? Naoto On 3/18/16 10:53 AM, Naoto Sato wrote: Hello, Please review the fix to the following bug: https://bugs.openjdk.java.net/browse/JDK-8060097 The proposed fix is loc