Re: RFR 8151281: Module java.httpclient could use System.Logger instead of PlatformLogger

2016-03-15 Thread Daniel Fuchs
On 15/03/16 06:35, Mandy Chung wrote: It’s a nice trick. Perhaps define a new internal class that implements System.Logger with default methods. Any platform classes want itself to be skipped will extend that new internal class? I thought the purpose here was to avoid using internal stuff r

RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-15 Thread vyom
Hi, Please review the below fix. Bug: JDK-8151586 : Wrong exception catch for FTPClient in JDK-8055032 Webrev :http://cr.openjdk.java.net/~rgoel/~vyom/8151586/webrev0.0/ Thanks, Vyom

RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

2016-03-15 Thread vyom
Hi, Please review the below fix. Bug: JDK-7167293 : FtpURLConnection connection leak on FileNotFoundException Webrev: http://cr.openjdk.java.net/~rgoel/~vyom/7167293/webrev0.0/ Thanks, Vyom

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-15 Thread Chris Hegarty
Vyom, On 15/03/16 09:51, vyom wrote: Hi, Please review the below fix. Bug: JDK-8151586 : Wrong exception catch for FTPClient in JDK-8055032 Webrev :http://cr.openjdk.java.net/~rgoel/~vyom/8151586/webrev0.0/ The source change lo

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

2016-03-15 Thread Chris Hegarty
Vyom, On 15/03/16 10:00, vyom wrote: Hi, Please review the below fix. Bug: JDK-7167293 : FtpURLConnection connection leak on FileNotFoundException Webrev: http://cr.openjdk.java.net/~rgoel/~vyom/7167293/webrev0.0/ You have the