On 28/01/2016 02:29, Martin Buchholz wrote:
Are y'all interested in our ipv6-only changes?
https://bugs.openjdk.java.net/browse/JDK-8148424
If yes, there will be some work on both sides, mostly for
multi-platform testing.
I think so, this is configuration that we attempted to test several
times,
On 27 Jan 2016, at 17:24, Claes Redestad wrote:
>
> On 2016-01-18 17:20, Claes Redestad wrote:
>>
>> The ability for URLStreamHandler implementations to override the parseURL
>> method seem to prevent this improvement unless we only do this for a subset
>> of known, well-behaved URLStreamHan
On 2016-01-28 16:52, Chris Hegarty wrote:
...
This looks fine Claes.
Thanks, Chris!
Maybe just a comment on the fact that character based comparison is
being used for perf reasons.
In an older version of the webrev, there was an updated to an existing test,
test/java/net/URI/URItoURLTest
On 28 Jan 2016, at 16:38, Claes Redestad wrote:
> On 2016-01-28 16:52, Chris Hegarty wrote:
>>> ...
>> This looks fine Claes.
>
> Thanks, Chris!
>
>>
>> Maybe just a comment on the fact that character based comparison is
>> being used for perf reasons.
>>
>> In an older version of the webrev,
This looks okay. I think it would be good to put a javadoc comment on
this method, also maybe move it to below all the constructors rather
than in the middle.
-Alan.
On 28/01/2016 16:38, Claes Redestad wrote:
On 2016-01-28 16:52, Chris Hegarty wrote:
...
This looks fine Claes.
Thanks
On 2016-01-28 20:56, Alan Bateman wrote:
This looks okay. I think it would be good to put a javadoc comment on
this method, also maybe move it to below all the constructors rather
than in the middle.
-Alan.
Sure, as this is package-private API a short description and reference
to the UR
