Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Alan Bateman
On 23/11/2015 04:12, Lu, Yingqi wrote: Hi Alan, One more question please JI want to make sure I understand correctly on your following suggestion. In order to use supportedOptions method to test SO_REUSEPORT, I will need to first write a native function to check if SO_REUSEPORT is supporte

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-11-23 Thread Alan Bateman
On 22/11/2015 16:09, Mark Sheppard wrote: Alan thanks for the feedback ... the implementation is based on what is currently being used in the tests via the existing set of NameService implementations. yes, the processing of the hosts file returns the first mapping it encounters. The function

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Volker Simonis
Hi Lucy, in general I support the addition of SO_REUSEPORT to the set of standard socket options. However for me the problem is not that this new option is not supported on all platforms, but instead that it has such different semantics on different platforms. If you look at the code, you'll see t

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Michael McMahon
How about the following for the apidoc in j.n.StandardSocketOptions? We can then reference this text from everywhere else rather than repeating it. (just noticed Lucy was not included in the last few mails) - Michael /** * Re-use port. * * The value of this socket option is

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Michael McMahon
I agree we should enable the option on all platforms. We can add the code to do that and run the tests. On the existing use of SO_REUSEPORT on AIX and Mac it appears that is set to emulate expected behavior on other platforms when SO_REUSEADDR is set for datagram sockets. The expectation is that

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Michael McMahon
Lucy, We can run the change through the standard test system here that will check it out on all platforms. Alan mentioned to me earlier that we could tweak the wording that I suggested to be more consistent with other options. So, I just need to check that with him. Thanks Michael. On 23/11

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Volker Simonis
On Mon, Nov 23, 2015 at 11:54 AM, Michael McMahon wrote: > I agree we should enable the option on all platforms. > We can add the code to do that and run the tests. > > On the existing use of SO_REUSEPORT on AIX and Mac > it appears that is set to emulate expected behavior on > other platforms whe

RE: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Lu, Yingqi
Michael/Volker/Alan, Thank you all very much for your feedback! Michael, I like your wording for SO_REUSEPORT in java.net.StandardSocketOptions and I will remove the link to the Linux page. It will be updated for the next version of the patch. Regarding to "reference this text from everywhere e

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Volker Simonis
I'll do the testing on AIX. Thanks, Volker On Mon, Nov 23, 2015 at 6:35 PM, Michael McMahon wrote: > Lucy, > > We can run the change through the standard test system here that will check > it out on all platforms. > > Alan mentioned to me earlier that we could tweak the wording that I > suggest