Re: RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified

2015-09-30 Thread Michael McMahon
Looks fine to me Rob - Michael On 25/09/15 13:54, Rob McKenna wrote: Good point. I'll remove that pre-push. -Rob On 25/09/15 11:57, Mark Sheppard wrote: Hi Rob, looks fine ... the "him" variable in the Java_java_net_Inet4AddressImpl_isReachable0 would appear not to be used now, s

[9] RFR 8137174: NTLM impl should use doPrivileged when it reads system properties

2015-09-30 Thread Artem Smotrakov
Hello, Please review this small fix which updates NTLM implementation to use doPrivileged() methods when it reads system properties. Currently it requires property permissions to read "ntlm.debug" and "ntlm.version" system properties. Also added a test which runs NTLM auth if security manager

Re: [9] RFR 8137174: NTLM impl should use doPrivileged when it reads system properties

2015-09-30 Thread Chris Hegarty
This looks ok to me Artem. -Chris On 30/09/15 11:11, Artem Smotrakov wrote: Hello, Please review this small fix which updates NTLM implementation to use doPrivileged() methods when it reads system properties. Currently it requires property permissions to read "ntlm.debug" and "ntlm.version" sy

Re: RFR: 8087112: HTTP API and HTTP/1.1 implementation

2015-09-30 Thread Michael McMahon
Hi, A new revision of the API can be seen at: http://cr.openjdk.java.net/~michaelm/8087112/04/ The main changes are: - package name change. Moved to own package java.net.httpclient - proxy setting uses ProxySelector (a static factory method will be added to ProxySelector for setting a simpl

Re: RFR: 8087112: HTTP API and HTTP/1.1 implementation

2015-09-30 Thread Michael McMahon
On 30/09/15 17:34, Michael McMahon wrote: Hi, A new revision of the API can be seen at: http://cr.openjdk.java.net/~michaelm/8087112/04/ The main changes are: - package name change. Moved to own package java.net.httpclient - proxy setting uses ProxySelector (a static factory method will be a