Looks good to me too.
-Chris.
On 23 Aug 2015, at 21:04, Claes Redestad wrote:
> Looks good to me.
>
> /Claes (not a Reviewer)
>
> On 2015-08-21 21:49, Rob McKenna wrote:
>> Hi folks, looking for a review for this simple change.
>>
>> The change for https://bugs.openjdk.java.net/browse/JDK-80
There are no close(), disconnect(), or similar method on
java.net.JarURLConnection nor it's super class (java.net.URLConnection).
My sample test program will close the resource when searching for an
"existing" file inside the jar file.
It only has resource leak (open file descriptor) when searchin
You're right, Neon!
I thought I saw close() somewhere in JarURLConnection, but it seems I
saw it somewhere else.
Peeking at code, I think it would help if you did:
jarUrlConnection.setUseCaches(false);
before invoking:
jarUrlConnection.getJarFile()/getJarEntry()/connect();
In case caches
