Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2015-01-29 Thread Alan Bateman
On 28/01/2015 21:40, Chris Hegarty wrote: I’ll make the change, add a test, and then update the webrev. On second thoughts, it shouldn't need to be changed because the child SOCKET is created before AcceptEx is used and so should already have the inherit flag set correctly. Has there been an

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2015-01-29 Thread Chris Hegarty
On 29 Jan 2015, at 09:21, Alan Bateman wrote: > On 28/01/2015 21:40, Chris Hegarty wrote: >> I’ll make the change, add a test, and then update the webrev. >> > On second thoughts, it shouldn't need to be changed because the child SOCKET > is created before AcceptEx is used and so should already

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2015-01-29 Thread Alan Bateman
On 29/01/2015 15:39, Chris Hegarty wrote: : Has there been any consideration given to writing a test for this? I thought we had one or two tests for this already. There are existing tests for client/connecting sockets, but none for accepted sockets. The test, and check, for accepted sockets

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-29 Thread Alan Bateman
On 26/01/2015 13:48, Seán Coffey wrote: Valeriy, those changes look fine to me and I've verified that they run through testing fine also. webrev here for reference : http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v3/webrev/ Can I have a jdk7u reviewer for this change ? There is a race