Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

2015-01-23 Thread Chris Hegarty
On 21.01.2015 16:06, Konstantin Shefov wrote: Hi, Chris I have done a pre-integration testing for this fix on Linux, Windows, Mac and Solaris x64 and sparc. I have run all regression tests for core libraries, and no new failures appeared. Can I push this change now or should I wait for an appro

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

2015-01-23 Thread Alan Bateman
On 23/01/2015 10:28, Chris Hegarty wrote: On 21.01.2015 16:06, Konstantin Shefov wrote: Hi, Chris I have done a pre-integration testing for this fix on Linux, Windows, Mac and Solaris x64 and sparc. I have run all regression tests for core libraries, and no new failures appeared. Can I push th

[8u-dev] Request for approval: JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

2015-01-23 Thread Konstantin Shefov
Hello, Please approve the direct backport of the bug fix to 8u-dev Patch applies cleanly to JDK 8u. The bug:https://bugs.openjdk.java.net/browse/JDK-6933879 The webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.01/ JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/801eb37fc

RFR 8071424: JCK test api/java_net/Socket/descriptions.html#Bind crashes on Windows

2015-01-23 Thread Chris Hegarty
This is a fix for a minor oversight when refactoring the initializing of Inet[4|6]Address IDs, used in many places in the networking native code. It would appear that there is an initInetAddressIDs() call missing from the Windows Dual Stacks Socket implementation, Java_java_net_DualStackPlainS

Re: [8u-dev] Request for approval: JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

2015-01-23 Thread Seán Coffey
Konstantin, can you hold off pushing this fix to jdk8u for the moment ? It's a P4 and could have behavioural consequences (something we try and avoid in update releases). I see JDK-8071458 was logged to track IPv6 scope specifications. Let's see how this soaks into JDK 9 over coming days and

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-23 Thread Seán Coffey
Valeriy, I didn't see a follow up on this. I've modified the patch so that we cater for a possible WSAEINVAL error to be returned from the NET_EnableFastTcpLoopback call. Latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v2/webrev/ changes only in http://cr.openjdk.java.n

Re: RFR 8071424: JCK test api/java_net/Socket/descriptions.html#Bind crashes on Windows

2015-01-23 Thread Alan Bateman
On 23/01/2015 13:51, Chris Hegarty wrote: This is a fix for a minor oversight when refactoring the initializing of Inet[4|6]Address IDs, used in many places in the networking native code. It would appear that there is an initInetAddressIDs() call missing from the Windows Dual Stacks Socket im

Re: RFR 8071424: JCK test api/java_net/Socket/descriptions.html#Bind crashes on Windows

2015-01-23 Thread Chris Hegarty
On 23/01/15 14:05, Alan Bateman wrote: On 23/01/2015 13:51, Chris Hegarty wrote: This is a fix for a minor oversight when refactoring the initializing of Inet[4|6]Address IDs, used in many places in the networking native code. It would appear that there is an initInetAddressIDs() call missing f

Re: RFR: 8065994: HTTP Tunnel connection to NTLM proxy reauthenticates instead of using keep-alive

2015-01-23 Thread Chris Hegarty
Looks good to me Sean. Good to see additional logging in this area. -Chris. On 22/01/15 15:21, Seán Coffey wrote: Looking for a review around this issue that came in as a reported performance regression in NTLM proxy authentication. It turned out that HttpsClients were being discarded after Pr

RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-23 Thread Martin Sawicki (MS OPEN TECH)
Sorry about the delay. Valeryi has prepared a patch - he'll be responding soon. From: Seán Coffey [mailto:sean.cof...@oracle.com] Sent: Friday, January 23, 2015 5:55 AM To: Valery Kopylov (Akvelon); Martin Sawicki (MS OPEN TECH); jdk7u-...@openjdk.java.net Cc: Kirk Shoop (MS OPEN TECH); OpenJDK N