Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

2014-10-31 Thread Volker Simonis
Hi, under the following link you can find an updated version of my change where I've fixed all indentation in Inet{4,6}AddressImpl.c to 4 spaces and changed the few C++-style comments (i.e. '//') to C-style comments (i.e. '/* */'): http://cr.openjdk.java.net/~simonis/webrevs/8060470.v2/ Can I pl

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

2014-10-31 Thread Bernd Eckenfels
Hello, I (still) like it. But I still think the AI_CANONNAME can and should be removed. If you keep it, it will trigger additional lookups and the actual canonized result (res->ai_canonname) is never used. This is true for all 3 locations (but you changed only one). I wonder if you want to make