Looks good for me!
-Dmitry
On 2014-10-01 02:26, Mark Sheppard wrote:
> Thanks Tom and Dmitry
>
> last up best dressed ...
>
> .invalid as the test domain is a good recommendation
>
> change is now
>
> --- a/test/java/net/InetAddress/IPv4Formats.javaTue Sep 30
> 13:25:04 2014 +0100
>
Hello!
This is a javadoc bug.
In the code sample a redundant argument to a constructor of URI is passed.
Probably a copy-paste error.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8059450
WEBREV: http://cr.openjdk.java.net/~igerasim/8059450/0/webrev/
Sincerely yours,
Ivan
Reviewed.
-Chris.
On 1 Oct 2014, at 00:01, Dmitry Samersoff wrote:
> Looks good for me!
>
> -Dmitry
>
> On 2014-10-01 02:26, Mark Sheppard wrote:
>> Thanks Tom and Dmitry
>>
>> last up best dressed ...
>>
>> .invalid as the test domain is a good recommendation
>>
>> change is now
>>
>> -
thanks Chris
On 01/10/2014 15:58, Chris Hegarty wrote:
Reviewed.
-Chris.
On 1 Oct 2014, at 00:01, Dmitry Samersoff wrote:
Looks good for me!
-Dmitry
On 2014-10-01 02:26, Mark Sheppard wrote:
Thanks Tom and Dmitry
last up best dressed ...
.invalid as the test domain is a good recommend
On 1 Oct 2014, at 01:48, Ivan Gerasimov wrote:
> Hello!
>
> This is a javadoc bug.
> In the code sample a redundant argument to a constructor of URI is passed.
> Probably a copy-paste error.
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8059450
> WEBREV: http://cr.openjdk.java.net/~igera
Thanks Chris!
On 01.10.2014 20:49, Chris Hegarty wrote:
On 1 Oct 2014, at 01:48, Ivan Gerasimov wrote:
Hello!
This is a javadoc bug.
In the code sample a redundant argument to a constructor of URI is passed.
Probably a copy-paste error.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-80594
