RFR: JDK-8040810 - Uninitialised memory in jdk/src/windows/native/java/net: net_util_md.c, TwoStacksPlainSocketImpl.c, TwoStacksPlainDatagramSocketImpl.c, DualStackPlainSocketImpl.c, DualStackPlainDa

2014-07-16 Thread Mark Sheppard
Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8040810/webrev/ which address the issue raised in https://bugs.openjdk.java.net/browse/JDK-8040810 resulting from static code analysis. these changes explicitly initialize local function variables, whic

Re: RFR: JDK-8040810 - Uninitialised memory in jdk/src/windows/native/java/net: net_util_md.c, TwoStacksPlainSocketImpl.c, TwoStacksPlainDatagramSocketImpl.c, DualStackPlainSocketImpl.c, DualStackPla

2014-07-16 Thread Alan Bateman
On 16/07/2014 18:00, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8040810/webrev/ which address the issue raised in https://bugs.openjdk.java.net/browse/JDK-8040810 resulting from static code analysis. these changes explicitl

Re: RFR: JDK-8040810 - Uninitialised memory in jdk/src/windows/native/java/net: net_util_md.c, TwoStacksPlainSocketImpl.c, TwoStacksPlainDatagramSocketImpl.c, DualStackPlainSocketImpl.c, DualStackPla

2014-07-16 Thread Mark Sheppard
HI Alan, thanks for the response ... yes, rv = 0 is isn't strictly necessary (in for a penny, in for a pound approach) regards Mark On 16/07/2014 18:28, Alan Bateman wrote: On 16/07/2014 18:00, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.j