Re: RFR JDK-8027308: HttpURLConnection should better handle URLs with literal IPv6 addresses

2014-06-08 Thread Chris Hegarty
This looks good to me Pavel. -Chris. On 6 Jun 2014, at 18:42, Pavel Rappo wrote: > Hi everyone, > > Could you please review my change for JDK-8027308? > > http://cr.openjdk.java.net/~prappo/8027308/webrev.00/ > > The issue in question actually consists of 2 issues. The first one is about >

Re: RFR JDK-8027308: HttpURLConnection should better handle URLs with literal IPv6 addresses

2014-06-08 Thread Alan Bateman
On 09/06/2014 06:40, Chris Hegarty wrote: This looks good to me Pavel. -Chris. It looks okay to me too, I was just wondering if it would be simpler to use host.substring + sb.append(']'). -Alan