RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-03 Thread Jonathan Lu
Hello, Could I have following patch reviewed for bug 8034954 ? http://cr.openjdk.java.net/~luchsh/JDK-8043954/ The patch is to fix a behavior difference of connect() API for AIX platform, according to the documentation, http://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.aix.commtrf

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-03 Thread Volker Simonis
Hi Jonathan, thanks for fixing this! I've looked at the change and it looks good to me (but I'm not a reviewer). The only minor flaw I found is that you declare the helper variable 'int rc = -1' but never assign it. Instead you could just return '-1' directly where you currently return 'rc' and re

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-03 Thread Jonathan Lu
Hi Volker, Thanks for your comment! an updated webrev was made at http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ On Tue, Jun 3, 2014 at 8:48 PM, Volker Simonis wrote: > Hi Jonathan, > > thanks for fixing this! I've looked at the change and it looks good to > me (but I'm not a reviewer). > Th