This looks mainly good to me.
Just a few small comments (mainly on the use of reflection):
1) jdk/net/Sockets.java
You could use a SharedSecret to access the private methods in the
public java.net package, but reflection is ok too.
2) If you stick with reflection then if a lookup of any o
On 11/04/14 10:27, Chris Hegarty wrote:
This looks mainly good to me.
Just a few small comments (mainly on the use of reflection):
1) jdk/net/Sockets.java
You could use a SharedSecret to access the private methods in the
public java.net package, but reflection is ok too.
I think the am
Reflection or shared secrets is a coin toss here, I think what you have
is okay. An alternative name for the package private class in java.net
is SocketSecrets, just a suggestion as SocketsUtil sounds more general
that it is.
I agree with Chris on throwing InternalError if any of the reflect
Thanks Alan. Points taken. I'll add the lambda to the 9 version also.
Michael
On 11/04/14 16:04, Alan Bateman wrote:
Reflection or shared secrets is a coin toss here, I think what you
have is okay. An alternative name for the package private class in
java.net is SocketSecrets, just a suggest
