Volker,
I’ve look at the following files:
src/share/native/sun/management/DiagnosticCommandImpl.c:
nit: “legel” -> “legal” (two times)
In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if you
allow dcmd_info_array to become NULL, then
jmm_interface->GetDiagnosticCommandInf
On 15/01/2014 06:24, David Holmes wrote:
I'm not a fan of runtime checks of this kind though if it is only a
very samll number of values it might be okay.
Another option would be to make those classes into "templates" as done
with Version.java.template and substitute the right values at buil
Yes, that looks like a good solution.
/Staffan
On 15 jan 2014, at 17:34, Volker Simonis wrote:
> Hi Staffan,
>
> thanks for the review. Please find my comments inline:
>
> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
> wrote:
> Volker,
>
> I’ve look at the following files:
>
> src/shar
On 15 jan 2014, at 18:27, Volker Simonis wrote:
> On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
> wrote:
>> Hi Staffan,
>>
>> thanks for the review. Please find my comments inline:
>>
>> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
>> wrote:
>>>
>>> Volker,
>>>
>>> I’ve look at the fo
On 15 jan 2014, at 18:52, Volker Simonis wrote:
>
>
> On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis
> wrote:
> > On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
> > wrote:
> >> Hi Staffan,
> >>
> >> thanks for the review. Please find my comments inline:
> >>
> >> On Wed, Jan 15, 2014 at 9
