Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-14 Thread Chris Hegarty
On 13 Jan 2014, at 19:29, Chris Hegarty wrote: > On 13 Jan 2014, at 19:23, Dimitar Mavrodiev wrote: > >> Hi Chris, >> >> I can't open the link, but yet I wouldn't mind if you folded your patch into >> mine. > > How embarrassing. Our public facing server is temporarily offline so I copied >

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-14 Thread Dimitar Mavrodiev
Hi Chris, I agree with those changes. Thank you and Alan for sponsoring this patch. On Tue, Jan 14, 2014 at 10:28 AM, Chris Hegarty wrote: > On 13 Jan 2014, at 19:29, Chris Hegarty wrote: > > > On 13 Jan 2014, at 19:23, Dimitar Mavrodiev > wrote: > > > >> Hi Chris, > >> > >> I can't open the

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-14 Thread Alan Bateman
On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage): I'd like to review this but I won'

RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-14 Thread Volker Simonis
Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage): http://cr.openjdk.java.net/~simonis/webrevs/8031581/ I've build and smoke tested

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-14 Thread Volker Simonis
Hi Alan, On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman wrote: > On 14/01/2014 08:40, Volker Simonis wrote: > >> Hi, >> >> could you please review the following changes for the ppc-aix-port >> stage/stage-9 repositories (the changes are planned for integration into >> ppc-aix-port/stage-9 and sub

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-14 Thread Alan Bateman
On 14/01/2014 08:28, Chris Hegarty wrote: On 13 Jan 2014, at 19:29, Chris Hegarty wrote: On 13 Jan 2014, at 19:23, Dimitar Mavrodiev wrote: Hi Chris, I can't open the link, but yet I wouldn't mind if you folded your patch into mine. How embarrassing. Our public facing server is temporari

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-14 Thread Chris Hegarty
On 14 Jan 2014, at 10:51, Alan Bateman wrote: > On 14/01/2014 08:28, Chris Hegarty wrote: >> On 13 Jan 2014, at 19:29, Chris Hegarty wrote: >> >>> On 13 Jan 2014, at 19:23, Dimitar Mavrodiev wrote: >>> Hi Chris, I can't open the link, but yet I wouldn't mind if you folded your

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-14 Thread David Holmes
Just a note on this part (I havent looked at the code): On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...) are defined to different values than on other operating systems. The problem is however, that these constants are hardcoded as public final static members of v

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-14 Thread roger riggs
Hi David, The CHECK_RETURN macros have existed in java.net for some time and I have not seen any empty statement warnings. The CHECK_EXCEPTION macros are new and does not have any uses yet. I don't plan to do any wholesale modification of current sources. The macros always produce a valid state

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-14 Thread Chris Hegarty
On 14 Jan 2014, at 10:53, Chris Hegarty wrote: > On 14 Jan 2014, at 10:51, Alan Bateman wrote: > >> On 14/01/2014 08:28, Chris Hegarty wrote: >>> On 13 Jan 2014, at 19:29, Chris Hegarty wrote: >>> On 13 Jan 2014, at 19:23, Dimitar Mavrodiev wrote: > Hi Chris, > > I c

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-14 Thread David Holmes
On 15/01/2014 12:10 AM, Volker Simonis wrote: On Tue, Jan 14, 2014 at 12:29 PM, David Holmes mailto:david.hol...@oracle.com>> wrote: Just a note on this part (I havent looked at the code): On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...) are def