One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous, with the call using parameter value "0"
could be just elided to using the null return value directly.
I was a bit confused also that the new function is in the TwoStacks...
module,
but it seems this file
Mark,
From what I can see, I think the changes are correct.
On 16/09/2013 11:10, Michael McMahon wrote:
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous, with the call using parameter value "0"
could be just elided to using the null return value direct
Hi Michael,
thanks for the response.
the getIPv4NetworkInterface is called in two places within the
getMulticastInterface function. It's a refactoring of what would have been
duplicate code. This lead to the "boolean" ipv4Mode.
line 2039
if (isIPV4) {
jobject netObject = NULL; //
Thanks Chris more lucid than my own reply
Mark
On 16/09/2013 11:33, Chris Hegarty wrote:
Mark,
From what I can see, I think the changes are correct.
On 16/09/2013 11:10, Michael McMahon wrote:
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous,
On 16/09/13 11:33, Chris Hegarty wrote:
Mark,
From what I can see, I think the changes are correct.
On 16/09/2013 11:10, Michael McMahon wrote:
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous, with the call using parameter value "0"
could be just eli
Not sure about Vista per se ... Initially I ran the test case on
windows 7 and the same failures existed
so on analysis and tracing lead me to the TwoStackPlainDatagramSocketImpl
I'm dependent on JPRT to handle the vista case ... if a Vista box exists
I can run the test explicitly on it to ensu
On 16/09/2013 12:11, Michael McMahon wrote:
...
yep. Forget that as well. I thought it was being called from common
code. So, I'm missing how this
code is relevant then on Vista, which should be using the dual stack
implementation then ?
Multicasting on Windows still uses the two stack impleme
On 16/09/13 13:53, Chris Hegarty wrote:
On 16/09/2013 12:11, Michael McMahon wrote:
...
yep. Forget that as well. I thought it was being called from common
code. So, I'm missing how this
code is relevant then on Vista, which should be using the dual stack
implementation then ?
Multicasting on
Changeset: 4ce8148ffc4f
Author:jlahoda
Date: 2013-09-16 14:13 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ce8148ffc4f
8021112: Spurious unchecked warning reported by javac
6480588: No way to suppress deprecation warnings when implementing deprecated
interface
Summa
Changeset: db0fc2b71298
Author:msheppar
Date: 2013-09-16 14:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db0fc2b71298
6458027: Disabling IPv6 on a specific network interface causes problems
Summary: added a check to test if an interface is configured for IPv6 to native
10 matches
Mail list logo
