Thanks for taking this Ivan.
Can you please make the changes suggested by both David and Alan (
simply return NULL/-1/JNI_FALSE, as appropriate, if GetStringUTFChars
fails ( returns NULL ), then I will sponsor this change into jdk8 for you.
Please post an update webrev to cr.openjdk.java.net.
Changeset: b8610a65fbf9
Author:vromero
Date: 2013-08-08 11:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9
8019486: javac, generates erroneous LVT for a test case with lambda code
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/comp/Lamb
Changeset: b7d594716f86
Author:weijun
Date: 2013-08-08 21:13 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7d594716f86
8016594: Native Windows ccache still reads DES tickets
Reviewed-by: dsamersoff, xuelei
! src/share/classes/sun/security/krb5/Credentials.java
! src/share/
Hello Chris!
Here's the update:
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/
Thanks for offering the sponsorship!
Here's the hg-export
http://cr.openjdk.java.net/~igerasim/2commit/8022584-jdk8-Memleak-in-NetworkInterface.patch
Sincerely yours,
Ivan
On 08.08.2013 12:43, Chris Hegarty
Thanks, David
I've updated the webrev
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/.
On 08.08.2013 9:01, David Holmes wrote:
Ivan,
On 8/08/2013 2:05 PM, Ivan Gerasimov wrote:
David, Alan,
I added checking for NULL results and throwing OOMException if
necessary.
You don't need
The patch looks good to me. I guess a regression test isn't feasible.
So, the bug will be tagged noreg-hard
Michael
On 08/08/13 14:39, Ivan Gerasimov wrote:
Thanks, David
I've updated the webrev
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/.
On 08.08.2013 9:01, David Holmes wrote:
Looks good to me. Thanks Ivan.
-Chris.
On 08/08/2013 02:33 PM, Ivan Gerasimov wrote:
Hello Chris!
Here's the update:
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/
Thanks for offering the sponsorship!
Here's the hg-export
http://cr.openjdk.java.net/~igerasim/2commit/8022584-jdk8-Memle
On 08/08/2013 06:39, Ivan Gerasimov wrote:
Thanks, David
I've updated the webrev
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/.
Thanks for fixing the other GetStringUTFChars usages too. This version
looks good to me.
-Alan.
Thank you Michael!
I'm working on the test.
Chris, if it's not too late, I would like to include a regtest into the
change.
It will be ready in a few minutes and I'll send an updated webrev.
Thanks,
Ivan
On 08.08.2013 17:51, Michael McMahon wrote:
The patch looks good to me. I guess a regre
Chris, if it's not too late, I'd like to include a regtest in the fix.
Here's webrev that includes the test:
http://cr.openjdk.java.net/~igerasim/8022584/3/webrev/
The test gets past with the fixed jdk8 and fails with jdk8-b101 and jdk7
as expected.
Sincerely yours,
Ivan
On 08.08.2013 17:50,
Changeset: a388263a7287
Author:sherman
Date: 2013-08-08 12:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a388263a7287
8015666: test/tools/pack200/TimeStamp.java failing
Summary: to keep the default behavior of ZOS unchanged, if ze extra time not
explicitly set
Reviewed-b
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Also this:
System.out.println("WARNING: Cannot perform memory leak detection on
this OS");
should probably just say something like "Test skipped on this OS" -
there are other tests that do
Yes, definitely "othervm" would be required for the test. Also, why skip
other OS'es?
The fix is only for Linux, but it might catch future leaks on Windows.
The trouble with tests like this, is they sometimes don't age well.
Future changes in OS kernel behavior could cause problems but I guess
Michael,
The test uses /proc/self/stat file to detect changes in virtual memory
usage.
This approach is specific for Linux.
That's why I included the check of OS in the test.
Sincerely yours,
Ivan
On 09.08.2013 1:38, Michael McMahon wrote:
Yes, definitely "othervm" would be required for the t
Thanks David!
On 09.08.2013 1:15, David Holmes wrote:
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Yes, it's a good point.
Since there may be a memory leak in the test, it'd better not interfere
with other tests in jtreg.
Also this:
Ivan,
Right, it's not worth trying to do the equivalent, whatever it is, for
Windows.
The test is fine with me.
Thanks
Michael
On 08/08/13 23:15, Ivan Gerasimov wrote:
Michael,
The test uses /proc/self/stat file to detect changes in virtual memory
usage.
This approach is specific for Linu
Thank you Michael!
On 09.08.2013 2:19, Michael McMahon wrote:
Ivan,
Right, it's not worth trying to do the equivalent, whatever it is, for
Windows.
The test is fine with me.
Thanks
Michael
On 08/08/13 23:15, Ivan Gerasimov wrote:
Michael,
The test uses /proc/self/stat file to detect chang
Ping.
Thanks,
Xuelei
On 8/7/2013 11:17 PM, Xuelei Fan wrote:
> Please review the new update:
>
> http://cr.openjdk.java.net./~xuelei/8020842/webrev.01/
>
> With this update, "com." is valid (return "com."); "." and
> "example..com" are invalid. And IAE will be thrown for invalid IDN.
>
> Than
I tried nslookup. Those with ".." inside are illegal,
$ nslookup com..
nslookup: 'com..' is not a legal name (empty label)
but
$ nslookup .
Server: 192.168.10.1
Address:192.168.10.1#53
Non-authoritative answer:
*** Can't find .: No answer
Also, since this bug was originally ab
On 8/9/2013 9:22 AM, Weijun Wang wrote:
> I tried nslookup. Those with ".." inside are illegal,
>
> $ nslookup com..
> nslookup: 'com..' is not a legal name (empty label)
>
> but
>
> $ nslookup .
> Server:192.168.10.1
> Address:192.168.10.1#53
>
> Non-authoritative answer:
> *** Can
On 8/9/13 9:37 AM, Xuelei Fan wrote:
On 8/9/2013 9:22 AM, Weijun Wang wrote:
I tried nslookup. Those with ".." inside are illegal,
$ nslookup com..
nslookup: 'com..' is not a legal name (empty label)
but
$ nslookup .
Server:192.168.10.1
Address:192.168.10.1#53
Non-authoritative
On 8/9/2013 10:14 AM, Weijun Wang wrote:
>
>
> On 8/9/13 9:37 AM, Xuelei Fan wrote:
>> On 8/9/2013 9:22 AM, Weijun Wang wrote:
>>> I tried nslookup. Those with ".." inside are illegal,
>>>
>>> $ nslookup com..
>>> nslookup: 'com..' is not a legal name (empty label)
>>>
>>> but
>>>
>>> $ nslookup
But, DNS considers "." as the valid root zone...
--
Sent from my mobile device.
Xuelei Fan wrote:
>On 8/9/2013 10:14 AM, Weijun Wang wrote:
>>
>>
>> On 8/9/13 9:37 AM, Xuelei Fan wrote:
>>> On 8/9/2013 9:22 AM, Weijun Wang wrote:
I tried nslookup. Those with ".." inside are illegal,
Changeset: 758e3117899c
Author:weijun
Date: 2013-08-09 11:41 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/758e3117899c
8021788: JarInputStream doesn't provide certificates for some file under
META-INF
Reviewed-by: chegar, sherman
! src/share/classes/java/util/jar/JarVerif
On 8/9/2013 11:24 AM, Matthew Hall wrote:
> But, DNS considers "." as the valid root zone...
>
Good! Looks like that IDN.toASCII(".") should returns ".", so that a
general domain name can always use IDN.toASCII() conversion instead of
throwing runtime exception.
Xuelei
Thanks for your feedback and suggestions.
Here is the new webrev:
http://cr.openjdk.java.net/~xuelei/8020842/webrev.02/
"." is regarded as valid IDN in this update.
Thanks,
Xuelei
On 8/9/2013 10:50 AM, Xuelei Fan wrote:
> On 8/9/2013 10:14 AM, Weijun Wang wrote:
>>
>>
>> On 8/9/13 9:37 AM, X
Thumbs up!
Thanks,
David
On 9/08/2013 8:19 AM, Ivan Gerasimov wrote:
Thanks David!
On 09.08.2013 1:15, David Holmes wrote:
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Yes, it's a good point.
Since there may be a memory leak in the te
Sorry I messed this up. The JNI book says GetStringUTFChars will return
NULL and post OOME but the JNI spec (latest version 6.0) does not - it
only says it will return NULL on failure.
So your previous version was the more correct. Given we just failed to
allocate C-heap I think we are on thin
Xuelei,
119 p = q + 1;
120 if (p < input.length() || q == (input.length() - 1)) {
Could be simplified to:
q <= input.length()-1
-Dmitry
On 2013-08-09 04:41, Xuelei Fan wrote:
> Ping.
>
> Thanks,
> Xuelei
>
> On 8/7/2013 11:17 PM, Xuelei Fan wrote:
>> Please review t
29 matches
Mail list logo
