On 07/05/13 14:43, Chris Hegarty wrote:
On 05/06/2013 10:28 PM, Kurchi Hazra wrote:
This looks okay to me.
Source changes look fine to me too. Probably best to add a test for '$'
In fact, Michael actually removed such a test [1] during another
change. We should get positive agreement from Mi
On 08/05/2013 10:35, Michael McMahon wrote:
On 07/05/13 14:43, Chris Hegarty wrote:
On 05/06/2013 10:28 PM, Kurchi Hazra wrote:
This looks okay to me.
Source changes look fine to me too. Probably best to add a test for '$'
In fact, Michael actually removed such a test [1] during another
chan
On 08/05/13 09:50, Chris Hegarty wrote:
On 08/05/2013 10:35, Michael McMahon wrote:
On 07/05/13 14:43, Chris Hegarty wrote:
On 05/06/2013 10:28 PM, Kurchi Hazra wrote:
This looks okay to me.
Source changes look fine to me too. Probably best to add a test for '$'
In fact, Michael actually re
Changeset: c8f47674d105
Author:alanb
Date: 2013-05-08 18:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8f47674d105
8013652: (profiles) Add javax.script to compact1
Reviewed-by: mchung, dholmes
! makefiles/profile-rtjar-includes.txt
Greetings:
I added a test for the leading dollar sign character in cookie names:
http://cr.openjdk.java.net/~jzavgren/7188517/webrev.03/
Thanks!
John
On 05/08/2013 08:33 AM, Michael McMahon wrote:
On 08/05/13 09:50, Chris Hegarty wrote:
On 08/05/2013 10:35, Michael McMahon wrote:
On 07/05/1
I would have thrown an exception if the IllegalArgumentException is not
obtained, otherwise the test looses its
purpose, and will pass silently if someone mistakenly removes the $
check in our code.
- Kurchi
On 5/8/2013 12:10 PM, John Zavgren wrote:
Greetings:
I added a test for the leading
Hi,
com.sun.net.httpServer uses a selector to get notified about interesting
events (such as arrival of a new connection, or data available to read
on an existing connection when using keep-alive), but imposes a timeout of
1000 ms on the select() operation. Although this is not a problem whe
On Wed, May 08, 2013 at 04:06:10PM -0700, Kurchi Hazra wrote:
> com.sun.net.httpServer uses a selector to get notified about interesting
> events (such as arrival of a new connection, or data available to read
> on an existing connection when using keep-alive), but imposes a timeout of
> 1000 ms on
On 5/8/2013 4:35 PM, Matthew Hall wrote:
On Wed, May 08, 2013 at 04:06:10PM -0700, Kurchi Hazra wrote:
com.sun.net.httpServer uses a selector to get notified about interesting
events (such as arrival of a new connection, or data available to read
on an existing connection when using keep-alive)
