Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

Looks good to me. Thanks, Kurchi On 1/22/13 6:50 PM, Frank Ding wrote: Hi Chris and Kurchi, Thank you both for your comments. I have reformatted the patch accordingly @ http://cr.openjdk.java.net/~dingxmin/7183373/webrev.03/ Please take a look again :-) Best regards, Frank On 1/22/2

hg: jdk8/tl/jdk: 8006741: javadoc cleanup for 6263419

Changeset: 71691b9d45ab Author:vinnie Date: 2013-01-23 09:49 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

On 23/01/2013 08:45, Kurchi Subhra Hazra wrote: Looks good to me. +1 Thanks Frank, -Chris. Thanks, Kurchi On 1/22/13 6:50 PM, Frank Ding wrote: Hi Chris and Kurchi, Thank you both for your comments. I have reformatted the patch accordingly @ http://cr.openjdk.java.net/~dingxmin/7183373/w

Re: RFR(XS) 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

On 22/01/2013 15:04, Chris Hegarty wrote: These tests started failing recently on some mac machines. They appear to hang and timeout. FAILED: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh FAILED: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/

Re: Code Review Request: 7017962: Obsolete link is used in URL class level spec

Thanks Kurchi, I'm ok with the changes you have. -Chris. On 23/01/2013 00:20, Kurchi Hazra wrote: The current javadoc for URL.java points to a non-existent link [1] to explain different types of URLs used by different protocols. The same document can currently be found at [2]. Bug: http://bugs

hg: jdk8/tl/jdk: 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

Changeset: bf2a14ebb6e9 Author:chegar Date: 2013-01-23 14:45 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ssl/sun/ne

hg: jdk8/tl/langtools: 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile

Changeset: 97bd5e7151bc Author:mcimadamore Date: 2013-01-23 15:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-

hg: jdk8/tl/jdk: 8006764: FunctionalInterface missing from rt.jar (old build)

Changeset: 53064bbaeec5 Author:alanb Date: 2013-01-23 15:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk

hg: jdk8/tl/jdk: 2 new changesets

Changeset: e0552f13f4a2 Author:sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb ! test/java/util/zip/ZipF

hg: jdk8/tl/langtools: 8006694: temporarily workaround combo tests are causing time out in several platforms

Changeset: 5c956be64b9e Author:vromero Date: 2013-01-23 20:57 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.c

hg: jdk8/tl/langtools: 8006775: JSR 308: Compiler changes in JDK8

Changeset: 71f35e4b93a5 Author:jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mer...@cs.washington.edu, wmdi...@cs.washington.edu, mp...@csail.mit.edu, m

hg: jdk8/tl/jdk: 8006591: Protect keystore entries using stronger PBE algorithms

Changeset: 0c86df653029 Author:vinnie Date: 2013-01-23 21:25 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java ! src/share/classes/su

hg: jdk8/tl/jdk: 8005408: KeyStore API enhancements

Changeset: 1da93663f8f3 Author:vinnie Date: 2013-01-23 23:13 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/java/security/PKCS12Attribute.j

hg: jdk8/tl/jdk: 8006813: Compilation error in PKCS12KeyStore.java

Changeset: 89f37f7188df Author:mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

Hi Kurchi, Thanks. Is it eligible for committing? Best regards, Frank On 1/23/2013 4:45 PM, Kurchi Subhra Hazra wrote: Looks good to me. Thanks, Kurchi On 1/22/13 6:50 PM, Frank Ding wrote: Hi Chris and Kurchi, Thank you both for your comments. I have reformatted the patch accordingly

hg: jdk8/tl/langtools: 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model

Changeset: 09f65aad4759 Author:darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/eleme