RFR 8006560: java/net/ipv6tests/B6521014.java fails intermittently

2013-01-18 Thread Chris Hegarty
This test can be seen to fail intermittently on a very busy system. The test tries to bind to a "hardcoded" (relative to another) port number. I see no reason for specify the port number in this testcase. The socket needs to be bound to a specific address, but we should be able to specify a por

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-18 Thread Chris Hegarty
I haven't been able to spend as much time on this as I would like, jdk8 M6 code freeze is approaching fast. Since this area is fraught with danger the safest change would be what is in the .2 version of the webrev [1]. I think I would be ok with this. -Chris. [1] http://cr.openjdk.java.net/~s

hg: jdk8/tl/langtools: 8006561: Langtools test failure: missing diags/examples

2013-01-18 Thread maurizio . cimadamore
Changeset: 3d84ae209919 Author:mcimadamore Date: 2013-01-18 15:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg + test/tools/javac/diags/examples/Unde

Re: RFR 8006560: java/net/ipv6tests/B6521014.java fails intermittently

2013-01-18 Thread Kurchi Subhra Hazra
Looks good - I looked into the bug details for the test too, but could not find any reason why we would need server and client to bind to consecutive ports. Thanks, - Kurchi On 1/18/13 6:23 AM, Chris Hegarty wrote: This test can be seen to fail intermittently on a very busy system. The test

RFR: JDK-8006568 HTTP protocol handler NLTM Authentication should use Base64 API

2013-01-18 Thread Mark Sheppard
Hi, as part of the Base64 API refactoring activity a review is requested for JDK-8006568 changes. Description: jdk8 has java.util.Base64 to define standard API. As part of a refactoring process to migrate core-libs to use this standard API, the NTLM Authentication support should be refactore

Re: RFR: JDK-8006568 HTTP protocol handler NLTM Authentication should use Base64 API

2013-01-18 Thread Chris Hegarty
Looks fine to me Mark. -Chris. On 01/18/2013 05:17 PM, Mark Sheppard wrote: Hi, as part of the Base64 API refactoring activity a review is requested for JDK-8006568 changes. Description: jdk8 has java.util.Base64 to define standard API. As part of a refactoring process to migrate core-li

Re: RFR: JDK-8006568 HTTP protocol handler NLTM Authentication should use Base64 API

2013-01-18 Thread Alan Bateman
On 18/01/2013 17:26, Chris Hegarty wrote: Looks fine to me Mark. -Chris. Looks good to me too. -Alan

hg: jdk8/tl/jdk: 8005120: Compiler warnings in socket transport native code

2013-01-18 Thread chris . hegarty
Changeset: f88e963960ae Author:jzavgren Date: 2013-01-18 17:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f88e963960ae 8005120: Compiler warnings in socket transport native code Reviewed-by: chegar, dsamersoff ! src/share/transport/socket/socketTransport.c ! src/share/tr

Re: RFR 8006560: java/net/ipv6tests/B6521014.java fails intermittently

2013-01-18 Thread Brad Wetmore
Looks good to me. Don't know how many of those we've cleaned over the years! ;) Brad On 1/18/2013 6:23 AM, Chris Hegarty wrote: This test can be seen to fail intermittently on a very busy system. The test tries to bind to a "hardcoded" (relative to another) port number. I see no reason for

hg: jdk8/tl/jdk: 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision

2013-01-18 Thread alan . bateman
Changeset: 06da8d0e Author:alanb Date: 2013-01-18 18:48 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06da8d0e 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision Reviewed-by: chegar ! src/solaris/classes/sun/