Re: java.net.URL.getBasePath() --> time to have it?

2013-01-17 Thread Michael McMahon
Hi Bruno, This sounds similar to what URI.resolve() provides: For example: new URI("http://www.foo.com/a/b/c";).resolve("") returns http://www.foo.com/a/b/ URL has a constructor which does something similar (the URL(URL, String) one) - Michael On 15/01/13 22:18, Bruno Borges wrote: Hey fo

Re: java.net.URL.getBasePath() --> time to have it?

2013-01-17 Thread Bruno Borges
Correct, that works. But perhaps another method to only return protocol+hostname+port would also be convenient? On 01/17/2013 02:38 PM, Michael McMahon wrote: Hi Bruno, This sounds similar to what URI.resolve() provides: For example: new URI("http://www.foo.com/a/b/c";).resolve("") ret

Re: RFR JDK-8005120

2013-01-17 Thread John Zavgren
Greetings: I would like you to review recent changes that I made to our native socket code for the purpose of eliminating compiler warnings. These changes boil down to passing parameters with the correct type to various system calls as well as one "opportunistic" change that corrects the impl

hg: jdk8/tl/langtools: 8005852: Treatment of '_' as identifier

2013-01-17 Thread maurizio . cimadamore
Changeset: 2d2b2be57c78 Author:mcimadamore Date: 2013-01-17 18:15 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/

Re: RFR JDK-8005120

2013-01-17 Thread Chris Hegarty
Thank you John, Looks fine to me. I can push it for you. -Chris. On 01/17/2013 06:07 PM, John Zavgren wrote: Greetings: I would like you to review recent changes that I made to our native socket code for the purpose of eliminating compiler warnings. These changes boil down to passing paramete

hg: jdk8/tl/jdk: 8006090: Formatter asserts with -esa

2013-01-17 Thread xueming . shen
Changeset: 787c7c1c210f Author:sherman Date: 2013-01-17 12:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/787c7c1c210f 8006090: Formatter asserts with -esa Summary: removed the offending assert Reviewed-by: alanb, darcy Contributed-by: brian.burkhal...@oracle.com ! src/sh

hg: jdk8/tl/jdk: 7171415: java.net.URI.equals/hashCode not consistent for some URIs

2013-01-17 Thread kurchi . subhra . hazra
Changeset: e8414d69692c Author:khazra Date: 2013-01-17 14:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8414d69692c 7171415: java.net.URI.equals/hashCode not consistent for some URIs Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed by vita..

hg: jdk8/tl/jdk: 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times

2013-01-17 Thread stuart . marks
Changeset: 79fed1733d4a Author:jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-17 Thread Frank Ding
Hi Michael, Could you please take a look at my comment below? Best regards, Frank On 1/6/2013 4:23 PM, Frank Ding wrote: Hi Michael, After reading carefully discussion thread, let me elaborate my investigation and conclusion. The 2nd version of Shirish's patch tries to address your conce