Thank you Max, looks fine to me.
-Chris.
On 12/12/2012 03:32, Weijun Wang wrote:
Hi Chris/Mark
I've added a makefile, please take a look
http://cr.openjdk.java.net/~weijun/8004904/webrev.00/
*build-dev* guys, I guess this won't affect the new build style.
Thanks
Max
On 12/12/2012 09:28 AM
Changeset: 12fba0974a9d
Author:weijun
Date: 2012-12-12 18:39 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12fba0974a9d
8004904: Makefile for ntlm
Reviewed-by: erikj, chegar
! make/com/sun/security/Makefile
+ make/com/sun/security/ntlm/Makefile
Changeset: 806cf26e5063
Author:chegar
Date: 2012-12-12 11:35 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/806cf26e5063
8004921: Trivial javadoc warnings in Base64
Reviewed-by: darcy
! src/share/classes/java/util/Base64.java
Changeset: 81640e75c7a7
Author:alanb
Date: 2012-12-12 13:03 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81640e75c7a7
8004874: Reduce dependency on java.beans to only
add/removePropertyChangeListener
Reviewed-by: ksrini, mchung, dholmes
! src/share/classes/com/sun/java/ut
The test tries to connect (through a socks proxy on the localhost) to a
domain that does not exist, "doesnt.exist.name". Guess what, someone
just registered a domain with that name!
The test should be updated to use a domain name that really doesn't exist.
>: hg diff SocksV4Test.java
diff -r
On 12/12/2012 14:02, Chris Hegarty wrote:
The test tries to connect (through a socks proxy on the localhost) to
a domain that does not exist, "doesnt.exist.name". Guess what, someone
just registered a domain with that name!
The test should be updated to use a domain name that really doesn't
Hi Chris,
I guess I figured if the parse failed the cal.set wouldn't happen.
Still, no harm in moving the 1970 into the loop on the off chance
something else goes wrong.
I've updated the test too. Thanks for spotting that.
-Rob
On 10/12/12 16:59, Chris Hegarty wrote:
Shouldn't 'cal.set
..the url would be helpful:
http://cr.openjdk.java.net/~robm/8000525/webrev.02/
-Rob
On 12/12/12 15:43, Rob McKenna wrote:
Hi Chris,
I guess I figured if the parse failed the cal.set wouldn't happen.
Still, no harm in moving the 1970 into the loop on the off chance
something else goes wro
Changeset: 68374c6e65c1
Author:robm
Date: 2012-12-12 15:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68374c6e65c1
8004337: java/sql tests aren't run in test/Makefile
Reviewed-by: lancea, alanb
! test/Makefile
On 12/12/2012 14:14, Alan Bateman wrote:
-Chris.
Would it be better if the test SocksServer had a list of knows that it
always rejects? That might speed up the test too as it would avoid is
trying to resolve host names or connect to hosts that don't exist.
The UHE is thrown from the cli
Thank you Rob, I'm ok with this change.
-Chris.
On 12/12/2012 15:44, Rob McKenna wrote:
...the url would be helpful:
http://cr.openjdk.java.net/~robm/8000525/webrev.02/
-Rob
On 12/12/12 15:43, Rob McKenna wrote:
Hi Chris,
I guess I figured if the parse failed the cal.set wouldn't happen.
Sti
On 12/12/2012 16:15, Chris Hegarty wrote:
On 12/12/2012 14:14, Alan Bateman wrote:
-Chris.
Would it be better if the test SocksServer had a list of knows that it
always rejects? That might speed up the test too as it would avoid is
trying to resolve host names or connect to hosts that do
Chris,
According to rfc2606 TLD .invalid is reserved for cases like this one,
So, it seems to me
domainame.invalid
is the best approach.
-Dmitry
On 2012-12-12 20:15, Chris Hegarty wrote:
>
> On 12/12/2012 14:14, Alan Bateman wrote:
>>
>>> -Chris.
>> Would it be better if the test S
On 12/12/2012 18:15, Dmitry Samersoff wrote:
Chris,
According to rfc2606 TLD .invalid is reserved for cases like this one,
Yes, I came across this, but there is nothing to stop an internal DNS
server from resolving .invalid domains. Anyway, may
"doesnot.exist.invalid" would be sufficient.
On 2012-12-12 22:29, Chris Hegarty wrote:
> On 12/12/2012 18:15, Dmitry Samersoff wrote:
>> Chris,
>>
>> According to rfc2606 TLD .invalid is reserved for cases like this one,
>
> Yes, I came across this, but there is nothing to stop an internal DNS
> server from resolving .invalid domains. Anyway
On 12 Dec 2012, at 19:01, Dmitry Samersoff wrote:
> On 2012-12-12 22:29, Chris Hegarty wrote:
>> On 12/12/2012 18:15, Dmitry Samersoff wrote:
>>> Chris,
>>>
>>> According to rfc2606 TLD .invalid is reserved for cases like this one,
>>
>> Yes, I came across this, but there is nothing to stop an
Changeset: 170e486632d9
Author:jlahoda
Date: 2012-12-12 20:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/170e486632d9
8004504: ListBuffer could reuse List.nil() as the sentinel element
Summary: ListBuffer.last now points to the last elements with client data, or
nu
Changeset: 56fd5479a98f
Author:jgish
Date: 2012-12-12 15:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f
8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete
file (win)
Summary: Failure to delete test log file should be a warning instea
Changeset: 5a2ab2c3f106
Author:weijun
Date: 2012-12-13 08:11 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106
8004235: Disable native JGSS provider on Mac
Reviewed-by: erikj, valeriep
! make/sun/security/Makefile
! makefiles/CompileNativeLibraries.gmk
! src/share/
On Tue, Dec 11, 2012 at 7:40 AM, Chris Hegarty wrote:
> Hi Martin,
>
> Thank you for reporting this issue. I filed 8004863: "Infinite Loop in
> KeepAliveStream", to track it.
>
> I put together a small test to reproduce the problem (inline below). It is
> racey, but shows the problem most of the t
Changeset: 7a8978a5bb6e
Author:lancea
Date: 2012-12-12 20:57 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e
8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread
Safety
Reviewed-by: naoto
! src/share/classes/javax/sql/rowset/serial/Seri
21 matches
Mail list logo