On 12/10/2012 09:06 PM, Dmitry Samersoff wrote:
Chris,
Looks good for me.
Thank you Dmitry,
PS:
Inet6Address.java:
It's not necessary to remove explicit initializations - compiler do it
perfectly for you.
This is a pet peeve of mine. I don't like to see them in code. javac
generates ex
On 10/12/12 20:48, Dmitry Samersoff wrote:
Michael,
On 2012-12-10 23:35, Michael McMahon wrote:
Could I get the following webrevs reviewed please?
They are identical changes (except for one small change suggested by
Dmitry)
to what was done in 8 for the same issues
http://cr.openjdk.java.net/~
On 10/12/12 16:01, Chris Hegarty wrote:
Inet6Address.getHostAddress() is specified to return the IP address
string in textual presentation, followed by a '%' character and the
scope identifier. This scope identifier can be either a numeric value
or a string, depending on how the instance was
Hi Martin,
Thank you for reporting this issue. I filed 8004863: "Infinite Loop in
KeepAliveStream", to track it.
I put together a small test to reproduce the problem (inline below). It
is racey, but shows the problem most of the time on my machine.
I tried your suggested patch, but found th
On 12/10/2012 07:37 PM, Kurchi Hazra wrote:
Looks good to me.
Thanks Kurchi.
Not related to this bug, but do we need scope_id_set then? From what I
infer, scope_id_set is being set in native code, only when
scope_id is not 0, and so a check with scope_id == 0 can serve the
purpose of scope_id
Changeset: cfde9737131e
Author:jjg
Date: 2012-12-11 15:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cfde9737131e
8004828: refactor init of *DocImpl classes
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java
! src/share/classes/
Changeset: c4bd81de2868
Author:akhil
Date: 2012-12-11 15:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bd81de2868
8003246: Add InitialValue Supplier to ThreadLocal
Reviewed-by: mduigou, forax, dl, chegar, briangoetz
! src/share/classes/java/lang/ThreadLocal.java
+ test
Hi Chris/Mark
I've added a makefile, please take a look
http://cr.openjdk.java.net/~weijun/8004904/webrev.00/
*build-dev* guys, I guess this won't affect the new build style.
Thanks
Max
On 12/12/2012 09:28 AM, Weijun Wang wrote:
On 12/12/2012 01:50 AM, Chris Hegarty wrote:
Max,
Mark
Changeset: 6c795437f212
Author:mduigou
Date: 2012-12-11 20:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c795437f212
8004905: Correct license of test to remove classpath exception
Reviewed-by: akhil
! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java