Frank,
Excellent! Thank you for doing it.
-Dmitry
On 2012-12-10 12:00, Frank Ding wrote:
> Hi Dmitry,
> I updated wording accordingly @
> http://cr.openjdk.java.net/~dingxmin/6512101/webrev.03. It is now
> changed to "Cannot get multibyte char for interface display name". What
> about that?
Hi Dmitry,
I updated wording accordingly @
http://cr.openjdk.java.net/~dingxmin/6512101/webrev.03. It is now
changed to "Cannot get multibyte char for interface display name". What
about that?
Best regards,
Frank
On 12/10/2012 3:43 PM, Dmitry Samersoff wrote:
Frank,
Looks good for me.
On 10/12/2012 08:01, Dmitry Samersoff wrote:
Frank,
Excellent! Thank you for doing it.
Ditto, thanks Frank.
I assume Sean or Neil will push this for you? Otherwise, just let me
know and I can do it.
-Chris.
-Dmitry
On 2012-12-10 12:00, Frank Ding wrote:
Hi Dmitry,
I updated wording
Changeset: c78acf6c2f3e
Author:mcimadamore
Date: 2012-12-10 12:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c78acf6c2f3e
8004094: Javac compiler error - synthetic method accessor generated with
duplicate name
Summary: method clash check logic should skip methods m
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/
We need to filter out extraneous authentication headers when doing
ntlm authentication with MS web servers and proxies.
Thanks
Michael
Looks fine.
-Max
On 12/10/2012 10:30 PM, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/
We need to filter out extraneous authentication headers when doing
ntlm authentication with MS web servers and proxies.
Tha
On 10/12/2012 14:34, Weijun Wang wrote:
Looks fine.
+1
-Chris
-Max
On 12/10/2012 10:30 PM, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/
We need to filter out extraneous authentication headers when doing
n
Thanks!
On 10/12/12 14:50, Chris Hegarty wrote:
On 10/12/2012 14:34, Weijun Wang wrote:
Looks fine.
+1
-Chris
-Max
On 12/10/2012 10:30 PM, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/
We need to filter
Michael,
150 It might be better to use regionMatches here
162 Is it intentional to always don't copy keys[0]/value[0] ?
Actually I would prefer to have this code better readable,
something like -
157 if ( ! ){
keys[j]=keys[j];
value[j]=value[j];
++j
Changeset: fda2b2b5b98b
Author:michaelm
Date: 2012-12-10 14:56 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda2b2b5b98b
8003948: NTLM/Negotiate authentication problem
Reviewed-by: chegar, weijun
! src/share/classes/sun/net/www/MessageHeader.java
! src/share/classes/sun/ne
Inet6Address.getHostAddress() is specified to return the IP address
string in textual presentation, followed by a '%' character and the
scope identifier. This scope identifier can be either a numeric value or
a string, depending on how the instance was created (if it was created
with a scoped
Shouldn't 'cal.set(1970, 0, 1, 0, 0, 0)' be inside the for loop?
The test can simply throw Exception, rather can catching.
Otherwise, looks fine to me.
-Crhis.
On 06/12/2012 21:19, Rob McKenna wrote:
Hi folks,
According to HttpCookie.java:
"""
There are 3 http cookie specifications:
Netsca
Could I get the following webrevs reviewed please?
They are identical changes (except for one small change suggested by Dmitry)
to what was done in 8 for the same issues
http://cr.openjdk.java.net/~michaelm/7200720.7u-dev/webrev.1/
http://cr.openjdk.java.net/~michaelm/8003948.7u-dev/webrev.1/
T
Looks good to me.
Not related to this bug, but do we need scope_id_set then? From what I
infer, scope_id_set is being set in native code, only when
scope_id is not 0, and so a check with scope_id == 0 can serve the
purpose of scope_id_set too.
Thanks,
Kurchi
On 10.12.2012 08:01, Chris Hegart
Michael,
On 2012-12-10 23:35, Michael McMahon wrote:
> Could I get the following webrevs reviewed please?
> They are identical changes (except for one small change suggested by
> Dmitry)
> to what was done in 8 for the same issues
>
> http://cr.openjdk.java.net/~michaelm/7200720.7u-dev/webrev.1/
Chris,
Looks good for me.
PS:
Inet6Address.java:
It's not necessary to remove explicit initializations - compiler do it
perfectly for you.
-Dmitry
On 2012-12-10 20:01, Chris Hegarty wrote:
>
> Inet6Address.getHostAddress() is specified to return the IP address
> string in textual presentatio
Changeset: cac1bfaceaaa
Author:mchung
Date: 2012-12-10 15:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa
4819681: Typo in
http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html
Summary: Simple capitalization typo in LogManager() description
Hi sun/net/www maintainers,
Here at Google we have observed an infinite loop
in jdk/src/share/classes/sun/net/www/http/KeepAliveStream.java
85: if (nskip <= available()) {
86: long n = 0;
87: while (n < nskip) {
88:
Hi All,
Thank you all. I will have Jonathan help to commit.
Best regards,
Frank
On 12/10/2012 6:12 PM, Chris Hegarty wrote:
On 10/12/2012 08:01, Dmitry Samersoff wrote:
Frank,
Excellent! Thank you for doing it.
Ditto, thanks Frank.
I assume Sean or Neil will push this for you? Otherwise
Changeset: 883feced1cdd
Author:dingxmin
Date: 2012-12-11 10:42 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd
6512101: Incorrect encoding in NetworkInterface.getDisplayName()
Reviewed-by: chegar, dsamersoff
! src/windows/native/java/net/NetworkInterface.c
Hi Frank,
Patch pushed @ http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd
Best regards!
- Jonathan
On 12/11/2012 09:49 AM, Frank Ding wrote:
Hi All,
Thank you all. I will have Jonathan help to commit.
Best regards,
Frank
On 12/10/2012 6:12 PM, Chris Hegarty wrote:
On 10/12/2012 08
Thanks Jonathan.
On 12/11/2012 10:44 AM, Jonathan Lu wrote:
Hi Frank,
Patch pushed @ http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd
Best regards!
- Jonathan
On 12/11/2012 09:49 AM, Frank Ding wrote:
Hi All,
Thank you all. I will have Jonathan help to commit.
Best regards,
Frank
Changeset: d206e52bf8a6
Author:weijun
Date: 2012-12-11 13:14 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d206e52bf8a6
8004488: wrong permissions checked in krb5
Reviewed-by: xuelei
! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java
! src/share/classes/s
23 matches
Mail list logo
