Re: Indenting code?

2012-09-14 Thread Alan Bateman
On 14/09/2012 01:21, Brad Wetmore wrote: Netbean's automatic formatting does a pretty good job with new code. However, I think the general advice is to not change existing code just because. When you're dealing with multiple release families, it makes the merges much more difficult. Brad One

Re: Indenting code?

2012-09-14 Thread Michael McMahon
One useful feature in Netbeans is that you can select a block of code and just (re)format that. So, there's no need to worry about affecting the rest of the file you are editing. - Michael On 14/09/12 01:59, Weijun Wang wrote: On 09/14/2012 08:21 AM, Brad Wetmore wrote: Netbean's automatic f

hg: jdk8/tl/jdk: 3 new changesets

2012-09-14 Thread sean . mullan
Changeset: eae1384cff39 Author:mullan Date: 2012-09-14 10:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eae1384cff39 7176627: CertPath/jep124/PreferCRL_SoftFail test fails (Could not determine revocation status) Reviewed-by: xuelei ! src/share/classes/sun/security/provi

Re: Indenting code?

2012-09-14 Thread Chris Hegarty
On 14/09/12 12:20, Alan Bateman wrote: On 14/09/2012 01:21, Brad Wetmore wrote: Netbean's automatic formatting does a pretty good job with new code. However, I think the general advice is to not change existing code just because. When you're dealing with multiple release families, it makes the

hg: jdk8/tl/jdk: 7193302: Remove ConstructorProperties annotation from java.lang.management.LockInfo

2012-09-14 Thread mandy . chung
Changeset: 22d7a9f73a59 Author:mchung Date: 2012-09-14 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22d7a9f73a59 7193302: Remove ConstructorProperties annotation from java.lang.management.LockInfo Reviewed-by: alanb, sla, egahlin ! src/share/classes/java/lang/manage

Re: Indenting code?

2012-09-14 Thread Mike Duigou
On Sep 14 2012, at 09:27 , Chris Hegarty wrote: > On 14/09/12 12:20, Alan Bateman wrote: >> On 14/09/2012 01:21, Brad Wetmore wrote: >>> Netbean's automatic formatting does a pretty good job with new code. >>> However, I think the general advice is to not change existing code >>> just because. W

Re: Indenting code?

2012-09-14 Thread Jim Gish
While it is true that NB and Eclipse and other IDEs offer auto formatting and that will suit some us, I also no that there are some amongst us who still use emacs and vi and possibly other non-IDE editors. The first thing to agree on is what standard are we coding to. I had assumed it was the

hg: jdk8/tl/langtools: 7192073: (javac) minor refactoring of tree maker to help IDEs

2012-09-14 Thread kumar . x . srinivasan
Changeset: fabfd2710057 Author:ksrini Date: 2012-09-14 09:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fabfd2710057 7192073: (javac) minor refactoring of tree maker to help IDEs Reviewed-by: jjg Contributed-by: jan.lah...@oracle.com ! src/share/classes/com/sun/too

Proposed changes for Bug 7193520

2012-09-14 Thread John Zavgren
Greetings: This bug (7193520) was filed because there are obsolete checks in the openJDK native code that implements datagram sockets, e.g., src/solaris/native/java/net/PlainDatagramSocketImpl.c and it's Java counterpart: src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java The nativ

Re: Indenting code?

2012-09-14 Thread Dmitry Samersoff
Jim, IMHO, It's really boring task to format big peace of code manually. The worst scenario I could imagine - autoformat code by netbeans and then manually adjust it to some coding standard. Is it possible to: 1. Rich some common point between netbeans and old sun coding standard. 2. Provide a

Re: Proposed changes for Bug 7193520

2012-09-14 Thread Dmitry Samersoff
John, Changes look good for me. Few nits below. PlainDatagramSocketImpl.c 318 brackets is not necessary anymore 1644 whole #ifdef could be removed struct ip_mreqn mreqn; is not necessary anymore, 2283 the same 2294 #ifdef is not necessary anymore -Dmitry On 2012-09-14 22:2

Re: Proposed changes for Bug 7193520

2012-09-14 Thread John Zavgren
Thanks. - Original Message - From: dmitry.samers...@oracle.com To: john.zavg...@oracle.com Cc: net-dev@openjdk.java.net Sent: Friday, September 14, 2012 3:08:57 PM GMT -05:00 US/Canada Eastern Subject: Re: Proposed changes for Bug 7193520 John, Changes look good for me. Few nits below.

Re: Proposed changes for Bug 7193520

2012-09-14 Thread John Zavgren
I agree with all the changes you recommend except the last one... see below. - Original Message - From: dmitry.samers...@oracle.com To: john.zavg...@oracle.com Cc: net-dev@openjdk.java.net Sent: Friday, September 14, 2012 3:08:57 PM GMT -05:00 US/Canada Eastern Subject: Re: Proposed changes

hg: jdk8/tl: 3 new changesets

2012-09-14 Thread lana . steuck
Changeset: b85b44cced24 Author:jcoomes Date: 2012-09-05 12:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b85b44cced24 7196361: add hotspot/make/closed to hgforest.sh Reviewed-by: ohair ! make/scripts/hgforest.sh Changeset: 76844579fa4b Author:katleman Date: 2012-09

hg: jdk8/tl/jaxp: 2 new changesets

2012-09-14 Thread lana . steuck
Changeset: f19d63b2119a Author:katleman Date: 2012-09-06 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f19d63b2119a Added tag jdk8-b55 for changeset 7c2363666890 ! .hgtags Changeset: 40bbed6d2173 Author:katleman Date: 2012-09-13 13:15 -0700 URL: http:

hg: jdk8/tl/jaxws: 2 new changesets

2012-09-14 Thread lana . steuck
Changeset: 7813455ccdb0 Author:katleman Date: 2012-09-06 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7813455ccdb0 Added tag jdk8-b55 for changeset 109c9e1f2d85 ! .hgtags Changeset: e099c1eea1ed Author:katleman Date: 2012-09-13 13:15 -0700 URL: http

hg: jdk8/tl/langtools: 4 new changesets

2012-09-14 Thread lana . steuck
Changeset: 363e9198b9de Author:lana Date: 2012-09-10 17:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/363e9198b9de Merge Changeset: 27ba086a9b60 Author:katleman Date: 2012-09-13 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27ba0

hg: jdk8/tl/corba: 2 new changesets

2012-09-14 Thread lana . steuck
Changeset: bf1bb47414e1 Author:katleman Date: 2012-09-06 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/bf1bb47414e1 Added tag jdk8-b55 for changeset e8a0e84383d6 ! .hgtags Changeset: 1500fe4849e8 Author:katleman Date: 2012-09-13 13:14 -0700 URL: http

hg: jdk8/tl/hotspot: 23 new changesets

2012-09-14 Thread lana . steuck
Changeset: 153776c4cb6f Author:amurillo Date: 2012-08-24 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/153776c4cb6f 7194004: new hotspot build - hs24-b22 Reviewed-by: jcoomes ! make/hotspot_version Changeset: be82ef218872 Author:sla Date: 2012-08-22 10:0

Re: Proposed changes for Bug 7193520

2012-09-14 Thread Alan Bateman
On 14/09/2012 19:22, John Zavgren wrote: : The proposed changes to the code (http://cr.openjdk.java.net/~chegar/7193520/webrev.00/) eliminate distracting dead wood, and it makes it run (slightly) faster, because the run time checks are eliminated. It's good to remove this old and long unused

hg: jdk8/tl/jdk: 7189926: Reduce test size for default run. Add additional run enabling alternative hashing.

2012-09-14 Thread mike . duigou
Changeset: 92f3cda88d8e Author:mduigou Date: 2012-09-11 07:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92f3cda88d8e 7189926: Reduce test size for default run. Add additional run enabling alternative hashing. Reviewed-by: alanb ! test/java/util/Map/Collisions.java

Re: Proposed changes for Bug 7193520

2012-09-14 Thread Dmitry Samersoff
John, linux has both ip_mreq and ip_mreqn structs, but after better consideration, I think it's better to *leave this code as is* because ip_mreq is obsoleted and general direction should be to use ip_mreqn for all OS that have it but these changes clearly out of scope of this CR, -Dmitry On 20