GC closes my ServerSocket

2012-06-13 Thread Weijun Wang
Hi All I have a test that basically looks like: int p = new ServerSocket(0).getLocalPort(); // new Socket("localhost", p); Recently it's failing on solaris-i586, and after some investigation, I realize that the ServerSocket object is GC'ed and auto-closed. (But why only recen

Re: GC closes my ServerSocket

2012-06-13 Thread Alan Bateman
On 13/06/2012 09:38, Weijun Wang wrote: Hi All I have a test that basically looks like: int p = new ServerSocket(0).getLocalPort(); // new Socket("localhost", p); Recently it's failing on solaris-i586, and after some investigation, I realize that the ServerSocket object is GC'

Re: GC closes my ServerSocket

2012-06-13 Thread Chris Hegarty
On 13/06/2012 09:51, Alan Bateman wrote: On 13/06/2012 09:38, Weijun Wang wrote: Hi All I have a test that basically looks like: int p = new ServerSocket(0).getLocalPort(); // new Socket("localhost", p); Recently it's failing on solaris-i586, and after some investigation, I realize that

Re: GC closes my ServerSocket

2012-06-13 Thread Weijun Wang
Please anyone take a review: http://cr.openjdk.java.net/~weijun/7176574/webrev.00/ By assigning to a local variable hopefully it stays alive on the stack during the whole method. Noreg-self. *Chris*: I didn't indented the whole test by wrapping them into a try-finally (or try-with-resour

Re: GC closes my ServerSocket

2012-06-13 Thread Chris Hegarty
On 13/06/2012 10:23, Weijun Wang wrote: Please anyone take a review: http://cr.openjdk.java.net/~weijun/7176574/webrev.00/ By assigning to a local variable hopefully it stays alive on the stack during the whole method. If they don't then we have a real problem ;-) Noreg-self. *Chris*: I

Re: GC closes my ServerSocket

2012-06-13 Thread Weijun Wang
Updated: http://cr.openjdk.java.net/~weijun/7176574/webrev.01/ Thanks Max On 06/13/2012 05:52 PM, Chris Hegarty wrote: On 13/06/2012 10:23, Weijun Wang wrote: Please anyone take a review: http://cr.openjdk.java.net/~weijun/7176574/webrev.00/ By assigning to a local variable hopefully it

hg: jdk8/tl/jdk: 2 new changesets

2012-06-13 Thread kelly . ohair
Changeset: 9fd127ff51d5 Author:ohair Date: 2012-06-12 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fd127ff51d5 7176138: Fixes for missing close() calls and possible null pointer reference instead of fatal error Reviewed-by: dcubed ! src/share/demo/jvmti/hprof/hprof

Re: GC closes my ServerSocket

2012-06-13 Thread Chris Hegarty
Looks fine to me. Thanks for adding the finally block. -Chris. On 13/06/2012 11:50, Weijun Wang wrote: Updated: http://cr.openjdk.java.net/~weijun/7176574/webrev.01/ Thanks Max On 06/13/2012 05:52 PM, Chris Hegarty wrote: On 13/06/2012 10:23, Weijun Wang wrote: Please anyone take a revie

hg: jdk8/tl/jdk: 7176574: sun/security/krb5/auto/TcpTimeout.java failed with solaris-i586

2012-06-13 Thread weijun . wang
Changeset: 4435f8b20d08 Author:weijun Date: 2012-06-13 19:23 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4435f8b20d08 7176574: sun/security/krb5/auto/TcpTimeout.java failed with solaris-i586 Reviewed-by: chegar ! test/sun/security/krb5/auto/TcpTimeout.java

Re: GC closes my ServerSocket

2012-06-13 Thread Neil Richards
On Wed, 2012-06-13 at 17:23 +0800, Weijun Wang wrote: > Please anyone take a review: > > http://cr.openjdk.java.net/~weijun/7176574/webrev.00/ > > By assigning to a local variable hopefully it stays alive on the stack > during the whole method. > > Noreg-self. > > *Chris*: I didn't indente

Re: GC closes my ServerSocket

2012-06-13 Thread Weijun Wang
> Would this be a good candidate to use Automatic Resource Management ? Correct. I'll remember to use it the next time. Thanks Max On 06/13/2012 08:23 PM, Neil Richards wrote: On Wed, 2012-06-13 at 17:23 +0800, Weijun Wang wrote: Please anyone take a review: http://cr.openjdk.java.net/~

Re: GC closes my ServerSocket

2012-06-13 Thread Jim Gish
On 06/13/2012 08:48 AM, Weijun Wang wrote: Automatic Resource Management ? http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html try-with-resources I learned about it when I submitted a test change using try finally (It was recommend that I use this instead :-)