Re: Code Review Request : 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

2012-04-24 Thread Chris Hegarty
Kurchi, The change looks fine to me. Thanks for forward porting. Trivially, the indentation of getDefaultScopeID looks a little off. Specifically, L121 in the new file: ni_defaultIndexID = (*env)->GetStaticFieldID(env, c, "defaultIndex", "I");

hg: jdk8/tl/jdk: 7163865: Performance improvement for DateFormatSymbols.getZoneIndex(String)

2012-04-24 Thread littlee
Changeset: 2c35304e885a Author:youdwei Date: 2012-04-24 21:06 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c35304e885a 7163865: Performance improvement for DateFormatSymbols.getZoneIndex(String) Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java

hg: jdk8/tl/jdk: 7151434: java -jar -XX crashes java launcher

2012-04-24 Thread kumar . x . srinivasan
Changeset: f68c854fa584 Author:ksrini Date: 2012-04-24 10:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f68c854fa584 7151434: java -jar -XX crashes java launcher Reviewed-by: mchung, darcy ! src/share/bin/java.c ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/Te

Re: Code Review Request : 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

2012-04-24 Thread Kurchi Hazra
Thanks Chris. I will take your comments into account and push the patch. - Kurchi On 4/24/2012 5:46 AM, Chris Hegarty wrote: Kurchi, The change looks fine to me. Thanks for forward porting. Trivially, the indentation of getDefaultScopeID looks a little off. Specifically, L121 in the new fil

hg: jdk8/tl/jdk: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

2012-04-24 Thread kurchi . subhra . hazra
Changeset: fcdbd1f34309 Author:khazra Date: 2012-04-24 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcdbd1f34309 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup() Summary: Get default interface for Mac OS X w

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-24 Thread Deven You
Hi Michael, I have done some search with google, there is an introduction says when sending a socket bound with INADDR_ANY, it will be sent to the default IP address (default address is the one has the lowest-numbered interface). I guess most Unix like OS should support the ping command, I al

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-24 Thread Deven You
Hi Michael, I also add the bug number into the test case[1], please review it: [1] http://cr.openjdk.java.net/~youdwei/inet4adr/webrev.01/ Thanks a lot! On 04/23/2012 05:56 PM, Michael McMahon wrote: Deven, The change looks benign enough, but my only concern is that not all operating systems